You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Vitalii Tymchyshyn (JIRA)" <ji...@apache.org> on 2012/08/01 12:47:03 UTC

[jira] [Created] (PIG-2853) PiggyBank XMLLoaderBufferedPositionedInputStream incorrectly inherits from BufferedPositionedInputStream and so uses unbuffered io reading byte-by-byte

Vitalii Tymchyshyn created PIG-2853:
---------------------------------------

             Summary: PiggyBank XMLLoaderBufferedPositionedInputStream incorrectly inherits from BufferedPositionedInputStream and so uses unbuffered io reading byte-by-byte
                 Key: PIG-2853
                 URL: https://issues.apache.org/jira/browse/PIG-2853
             Project: Pig
          Issue Type: Bug
          Components: piggybank
    Affects Versions: 0.10.0
            Reporter: Vitalii Tymchyshyn


XMLLoaderBufferedPositionedInputStream caches passed InputStream and then uses it to read. At the same time the stream is bufferent in super construcor. So cached version is unbuffered.

Also using cached version makes getPosition() call return invalid values and forces XMLLoaderBufferedPositionedInputStream maintain it's own counter.

I did add some fixes here: https://github.com/apache/pig/pull/5/files 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (PIG-2853) PiggyBank XMLLoaderBufferedPositionedInputStream incorrectly inherits from BufferedPositionedInputStream and so uses unbuffered io reading byte-by-byte

Posted by "Vitalii Tymchyshyn (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vitalii Tymchyshyn updated PIG-2853:
------------------------------------

    Attachment: diff.diff

The diff from pull request
                
> PiggyBank XMLLoaderBufferedPositionedInputStream incorrectly inherits from BufferedPositionedInputStream and so uses unbuffered io reading byte-by-byte
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: PIG-2853
>                 URL: https://issues.apache.org/jira/browse/PIG-2853
>             Project: Pig
>          Issue Type: Bug
>          Components: piggybank
>    Affects Versions: 0.10.0
>            Reporter: Vitalii Tymchyshyn
>         Attachments: diff.diff
>
>
> XMLLoaderBufferedPositionedInputStream caches passed InputStream and then uses it to read. At the same time the stream is bufferent in super construcor. So cached version is unbuffered.
> Also using cached version makes getPosition() call return invalid values and forces XMLLoaderBufferedPositionedInputStream maintain it's own counter.
> I did add some fixes here: https://github.com/apache/pig/pull/5/files 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (PIG-2853) PiggyBank XMLLoaderBufferedPositionedInputStream incorrectly inherits from BufferedPositionedInputStream and so uses unbuffered io reading byte-by-byte

Posted by "Vitalii Tymchyshyn (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vitalii Tymchyshyn updated PIG-2853:
------------------------------------

    Affects Version/s: 0.9.1
    
> PiggyBank XMLLoaderBufferedPositionedInputStream incorrectly inherits from BufferedPositionedInputStream and so uses unbuffered io reading byte-by-byte
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: PIG-2853
>                 URL: https://issues.apache.org/jira/browse/PIG-2853
>             Project: Pig
>          Issue Type: Bug
>          Components: piggybank
>    Affects Versions: 0.9.1, 0.10.0
>            Reporter: Vitalii Tymchyshyn
>         Attachments: diff.diff
>
>
> XMLLoaderBufferedPositionedInputStream caches passed InputStream and then uses it to read. At the same time the stream is bufferent in super construcor. So cached version is unbuffered.
> Also using cached version makes getPosition() call return invalid values and forces XMLLoaderBufferedPositionedInputStream maintain it's own counter.
> I did add some fixes here: https://github.com/apache/pig/pull/5/files 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira