You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "HTHou (via GitHub)" <gi...@apache.org> on 2023/07/28 02:24:08 UTC
[GitHub] [iotdb] HTHou commented on a diff in pull request #10709: build: Cleaned up the poms to match the new directory structure
HTHou commented on code in PR #10709:
URL: https://github.com/apache/iotdb/pull/10709#discussion_r1277012383
##########
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/executable/ExecutableManager.java:
##########
@@ -227,6 +228,8 @@ protected void saveToDir(ByteBuffer byteBuffer, String destination) throws IOExc
try {
Path path = Paths.get(destination);
Files.deleteIfExists(path);
+ // Ensure the target directory exists.
+ SystemFileFactory.INSTANCE.makeDirIfNecessary(destination);
Review Comment:
The destination String is not a Dir path, it is a file path I believe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org