[jira] [Commented] (HADOOP-14439) regression: secret stripping from S3x URIs breaks some downstream code

["Steve Loughran (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-14439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153695#comment-16153695 ] 

Steve Loughran commented on HADOOP-14439:
-----------------------------------------

OK, so this is reverting the URI fixup. LGTM  though we need to call it out in the release notes

One thing I'm thinking of here is: should we patch s3n to tell of users too?  All we need is to call {{extractLoginDetailsWithWarnings()}} in the S3N init code?

> regression: secret stripping from S3x URIs breaks some downstream code
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-14439
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14439
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs/s3
>    Affects Versions: 2.8.0
>         Environment: Spark 2.1
>            Reporter: Steve Loughran
>            Assignee: Vinayakumar B
>            Priority: Minor
>         Attachments: HADOOP-14439-01.patch, HADOOP-14439-02.patch
>
>
> Surfaced in SPARK-20799
> Spark is listing the contents of a path with getFileStatus(path), then looking up the path value doing a lookup of the contents.
> Apparently the lookup is failing to find files if you have a secret in the key, {{s3a://key:secret@bucket/path}}. 
> Presumably this is because the stripped values aren't matching.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org