You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by jp...@apache.org on 2018/05/21 21:10:55 UTC

[2/3] mesos git commit: Disabled omission of frame pointers in debug builds in stout.

Disabled omission of frame pointers in debug builds in stout.

This patch prevents the compiler from omitting frame pointers for
debug builds which can lead to a better debugging or profiling
experience.

Since having this flag turned on can disable certain optimizations we
do not enable it in non-debug builds. This can lead to minor
deviations in runtime behavior when combing release and debug flags
(e.g., when combining `--enable-debug` with `--enable-optimize`, or
with the cmake build type `RelWithDebInfo`), but still should give the
best possible build for pure release builds, and allow a reasonable
developer experience when debugging/profiling.

Review: https://reviews.apache.org/r/67109/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/1e119611
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/1e119611
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/1e119611

Branch: refs/heads/master
Commit: 1e119611cbfe7d2385014cafed95af22ccc682a0
Parents: 63089ef
Author: Benjamin Bannier <be...@mesosphere.io>
Authored: Mon May 21 13:57:45 2018 -0700
Committer: James Peach <jp...@apache.org>
Committed: Mon May 21 13:57:45 2018 -0700

----------------------------------------------------------------------
 3rdparty/stout/configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/1e119611/3rdparty/stout/configure.ac
----------------------------------------------------------------------
diff --git a/3rdparty/stout/configure.ac b/3rdparty/stout/configure.ac
index 5a8c023..7e85c7e 100644
--- a/3rdparty/stout/configure.ac
+++ b/3rdparty/stout/configure.ac
@@ -210,7 +210,7 @@ AM_CONDITIONAL([OPTIMIZE], [test x"$enable_optimize" = "xyes"])
 
 debug_flags="-g1"
 if test "x$enable_debug" = "xyes"; then
-  debug_flags="-g"
+  debug_flags="-g -fno-omit-frame-pointer"
 elif test "x$enable_optimize" = "xyes"; then
   debug_flags=""
 fi