[GitHub] [ozone] sodonnel commented on pull request #3360: HDDS-6663. remove container reference from scm if its state is DELETED

[GitBox <gi...@apache.org>]

sodonnel commented on PR #3360:
URL: https://github.com/apache/ozone/pull/3360#issuecomment-1286723890

   IMO I think this change looks good. Perhaps we should add one more test that confirms the reference is not deleted if the config flag is false, just to catch any future changes which may break this.
   
   I also believe that the best thing is to have this "delete empty container references" on by default as in the normal case, there is no real reason to want to keep an empty reference around.
   
   We should probably log it is being removed however, so there is some trace or indication about why it disappeared.
   
   @errose28 what do you think? You had some differing opinions on this before?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org