You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by ok...@apache.org on 2016/10/07 12:19:50 UTC
tinkerpop git commit: removed a GremlinServer test that assumes a
particular traverser count. This shouldn't be assumed given that Gremlin does
not guarantee traversers counts nor ordering. Thus,
any tests that assume such things without explicit steps t
Repository: tinkerpop
Updated Branches:
refs/heads/master a829e9d62 -> abc9d7af0
removed a GremlinServer test that assumes a particular traverser count. This shouldn't be assumed given that Gremlin does not guarantee traversers counts nor ordering. Thus, any tests that assume such things without explicit steps that dictate such matters (e.g. barrier() and order()) should not exist. This is why ProfileTest (looking scornfully at you @rjbriody) is the bane of our existence. It assumes not only traverser counts, but also traversal step structure. Daaaaaaah.
Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/abc9d7af
Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/abc9d7af
Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/abc9d7af
Branch: refs/heads/master
Commit: abc9d7af0a1cd7d6809ca4c04792467a8b209d94
Parents: a829e9d
Author: Marko A. Rodriguez <ok...@gmail.com>
Authored: Fri Oct 7 06:19:42 2016 -0600
Committer: Marko A. Rodriguez <ok...@gmail.com>
Committed: Fri Oct 7 06:19:42 2016 -0600
----------------------------------------------------------------------
.../gremlin/server/GremlinResultSetIntegrateTest.java | 12 ------------
1 file changed, 12 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/abc9d7af/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinResultSetIntegrateTest.java
----------------------------------------------------------------------
diff --git a/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinResultSetIntegrateTest.java b/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinResultSetIntegrateTest.java
index d149d7c..3c1efef 100644
--- a/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinResultSetIntegrateTest.java
+++ b/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinResultSetIntegrateTest.java
@@ -93,18 +93,6 @@ public class GremlinResultSetIntegrateTest extends AbstractGremlinServerIntegrat
}
@Test
- public void shouldHandleVertexResultFromTraversal() throws Exception {
- final Graph graph = TinkerGraph.open();
- final GraphTraversalSource g = graph.traversal();
- final Client aliased = client.alias("g");
- final ResultSet resultSet = aliased.submit(g.V().both().both());
- final List<Result> results = resultSet.all().get();
-
- assertThat(results.get(0).getObject(), CoreMatchers.instanceOf(Traverser.class));
- assertEquals(30, results.size());
- }
-
- @Test
public void shouldHandleVertexResultFromTraversalBulked() throws Exception {
final Graph graph = TinkerGraph.open();
final GraphTraversalSource g = graph.traversal();