You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/06/17 16:13:01 UTC

[GitHub] [geode] yozaner1324 opened a new pull request #5264: GEODE-8271 - Update Spring artifacts to latest patch versions.

yozaner1324 opened a new pull request #5264:
URL: https://github.com/apache/geode/pull/5264


   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] kohlmu-pivotal commented on a change in pull request #5264: GEODE-8271 - Update Spring artifacts to latest patch versions.

Posted by GitBox <gi...@apache.org>.
kohlmu-pivotal commented on a change in pull request #5264:
URL: https://github.com/apache/geode/pull/5264#discussion_r451837460



##########
File path: buildSrc/src/main/groovy/org/apache/geode/gradle/plugins/DependencyConstraints.groovy
##########
@@ -249,7 +249,7 @@ class DependencyConstraints implements Plugin<Project> {
       entry('spring-security-oauth2-jose')
     }
 
-    dependencySet(group: 'org.springframework', version: '5.2.5.RELEASE') {
+    dependencySet(group: 'org.springframework', version: '5.2.7.RELEASE') {

Review comment:
       Oversight perhaps. Will go through this list again when we re-open this PR




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] kohlmu-pivotal commented on a change in pull request #5264: GEODE-8271 - Update Spring artifacts to latest patch versions.

Posted by GitBox <gi...@apache.org>.
kohlmu-pivotal commented on a change in pull request #5264:
URL: https://github.com/apache/geode/pull/5264#discussion_r451837160



##########
File path: geode-assembly/src/integrationTest/resources/dependency_classpath.txt
##########
@@ -16,6 +15,7 @@ geode-redis-0.0.0.jar
 geode-serialization-0.0.0.jar
 geode-tcp-server-0.0.0.jar
 geode-wan-0.0.0.jar
+geode-management-0.0.0.jar

Review comment:
       Don't we touched this.. but we'll pay attention when we re-open this PR

##########
File path: geode-assembly/src/integrationTest/resources/dependency_classpath.txt
##########
@@ -16,6 +15,7 @@ geode-redis-0.0.0.jar
 geode-serialization-0.0.0.jar
 geode-tcp-server-0.0.0.jar
 geode-wan-0.0.0.jar
+geode-management-0.0.0.jar

Review comment:
       Don't think we touched this.. but we'll pay attention when we re-open this PR




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] yozaner1324 closed pull request #5264: GEODE-8271 - Update Spring artifacts to latest patch versions.

Posted by GitBox <gi...@apache.org>.
yozaner1324 closed pull request #5264:
URL: https://github.com/apache/geode/pull/5264


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5264: GEODE-8271 - Update Spring artifacts to latest patch versions.

Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on a change in pull request #5264:
URL: https://github.com/apache/geode/pull/5264#discussion_r451788138



##########
File path: buildSrc/src/main/groovy/org/apache/geode/gradle/plugins/DependencyConstraints.groovy
##########
@@ -249,7 +249,7 @@ class DependencyConstraints implements Plugin<Project> {
       entry('spring-security-oauth2-jose')
     }
 
-    dependencySet(group: 'org.springframework', version: '5.2.5.RELEASE') {
+    dependencySet(group: 'org.springframework', version: '5.2.7.RELEASE') {

Review comment:
       any reason not to bump springframework.security to 5.3.3 at the same time?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5264: GEODE-8271 - Update Spring artifacts to latest patch versions.

Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on a change in pull request #5264:
URL: https://github.com/apache/geode/pull/5264#discussion_r451786468



##########
File path: geode-assembly/src/integrationTest/resources/dependency_classpath.txt
##########
@@ -16,6 +15,7 @@ geode-redis-0.0.0.jar
 geode-serialization-0.0.0.jar
 geode-tcp-server-0.0.0.jar
 geode-wan-0.0.0.jar
+geode-management-0.0.0.jar

Review comment:
       why move this out of alphabetical order?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org