[GitHub] [dubbo] kylixs edited a comment on pull request #9015: [3.0] change getRegistries return type to HashSet for unique, create different zkClient for different application

[GitBox <gi...@apache.org>]

kylixs edited a comment on pull request #9015:
URL: https://github.com/apache/dubbo/pull/9015#issuecomment-942897754


   You need to change the `ZookeeperTransporter` scope to APPLICATION to prevent zK client data of different applications from being mixed.   
   ZK clients are created  in `ZookeeperTransporter` , so it best to destroy them in `ZookeeperTransporter` only. see https://github.com/apache/dubbo/pull/9033#discussion_r727950077
   
   ```java
   @SPI(scope = ExtensionScope.FRAMEWORK)
   public interface ZookeeperTransporter {
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org