You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/06/16 00:05:29 UTC
[GitHub] [helix] mgao0 opened a new issue, #2160: HelixManagerFactory doesn't support instantiating ZKHelixManager with HelixManagerProperty for Non-MSDS use cases
mgao0 opened a new issue, #2160:
URL: https://github.com/apache/helix/issues/2160
### Describe the bug
` public static HelixManager getZKHelixManager(String clusterName, String instanceName,
InstanceType type, HelixManagerStateListener stateListener,
HelixManagerProperty helixManagerProperty);` only works for ZooScalability cases.
Reason:
If user passes in HelixManagerProperty in the call to this method, right now the code treats it as a ZooScalability use case, so it will try to connect using the ZooScalability logic.
It was fine until now because non-ZooScalability users will use another method in the HelixManagerFactory ` public static HelixManager getZKHelixManager(String clusterName, String instanceName,
InstanceType type, String zkAddr, HelixManagerStateListener stateListener) ` to pass in zkAddr, so it will connect as the traditional way.
But the need for non-ZooScalability users to use the method with HelixManagerProperty emerges because HelixManagerProperty contains HelixCloudProperty. So backward compatibility support for ` public static HelixManager getZKHelixManager(String clusterName, String instanceName,
InstanceType type, HelixManagerStateListener stateListener,
HelixManagerProperty helixManagerProperty);` is needed, so it will support non-ZooScalability use cases as well.
### To Reproduce
Steps to reproduce the behavior.
### Expected behavior
A clear and concise description of what you expected to happen.
### Additional context
Add any other context about the problem here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] mgao0 closed issue #2160: HelixManagerFactory doesn't support instantiating ZKHelixManager with HelixManagerProperty for Non-MSDS use cases
Posted by GitBox <gi...@apache.org>.
mgao0 closed issue #2160: HelixManagerFactory doesn't support instantiating ZKHelixManager with HelixManagerProperty for Non-MSDS use cases
URL: https://github.com/apache/helix/issues/2160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org