You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Ariel Weisberg (JIRA)" <ji...@apache.org> on 2015/08/14 20:59:46 UTC
[jira] [Comment Edited] (CASSANDRA-9749) CommitLogReplayer
continues startup after encountering errors
[ https://issues.apache.org/jira/browse/CASSANDRA-9749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14697553#comment-14697553 ]
Ariel Weisberg edited comment on CASSANDRA-9749 at 8/14/15 6:59 PM:
--------------------------------------------------------------------
Should [this|https://github.com/apache/cassandra/compare/cassandra-2.2...blambov:9749-2.2#diff-238274682889110497be5a5cb1eca986R143] and [this|https://github.com/apache/cassandra/compare/cassandra-2.2...blambov:9749-2.2#diff-238274682889110497be5a5cb1eca986R153] have an @Test annotation?
You are correct about the coverage being wrong. I ran it in the debugger and it stops there. That's really unfortunate. I'll take a look at possible reasons why emma can get confused.
If you work out the annotation issue then I am +1.
was (Author: aweisberg):
Should [this|https://github.com/apache/cassandra/compare/cassandra-2.2...blambov:9749-2.2#diff-238274682889110497be5a5cb1eca986R143] and [this|https://github.com/apache/cassandra/compare/cassandra-2.2...blambov:9749-2.2#diff-238274682889110497be5a5cb1eca986R153] have an @Test annotation?
> CommitLogReplayer continues startup after encountering errors
> -------------------------------------------------------------
>
> Key: CASSANDRA-9749
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9749
> Project: Cassandra
> Issue Type: Bug
> Reporter: Blake Eggleston
> Assignee: Branimir Lambov
> Fix For: 2.2.x
>
> Attachments: 9749-coverage.tgz
>
>
> There are a few places where the commit log recovery method either skips sections or just returns when it encounters errors.
> Specifically if it can't read the header here: https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/commitlog/CommitLogReplayer.java#L298
> Or if there are compressor problems here: https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/commitlog/CommitLogReplayer.java#L314 and here: https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/commitlog/CommitLogReplayer.java#L366
> Whether these are user-fixable or not, I think we should require more direct user intervention (ie: fix what's wrong, or remove the bad file and restart) since we're basically losing data.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)