You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Pan Jie (JIRA)" <ji...@apache.org> on 2009/04/21 12:20:47 UTC

[jira] Created: (SHINDIG-1026) fix signing fetcher warning for empty path

fix signing fetcher warning for empty path
------------------------------------------

                 Key: SHINDIG-1026
                 URL: https://issues.apache.org/jira/browse/SHINDIG-1026
             Project: Shindig
          Issue Type: Bug
          Components: PHP
    Affects Versions: trunk
            Reporter: Pan Jie
            Priority: Minor
             Fix For: trunk


For empty path like http://example.org
SigningFetcher will echo warning message because $parsedUri['path'] is null.
So makeRequest will failed with this warning message.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (SHINDIG-1026) fix signing fetcher warning for empty path

Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Chabot resolved SHINDIG-1026.
-----------------------------------

    Resolution: Fixed
      Assignee: Chris Chabot

This patch has already been applied a while ago; Closing

> fix signing fetcher warning for empty path
> ------------------------------------------
>
>                 Key: SHINDIG-1026
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1026
>             Project: Shindig
>          Issue Type: Bug
>          Components: PHP
>    Affects Versions: 1.1-BETA1
>            Reporter: Pan Jie
>            Assignee: Chris Chabot
>            Priority: Minor
>             Fix For: 1.1-BETA2
>
>         Attachments: 20090421-2.patch
>
>
> For empty path like http://example.org
> SigningFetcher will echo warning message because $parsedUri['path'] is null.
> So makeRequest will failed with this warning message.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (SHINDIG-1026) fix signing fetcher warning for empty path

Posted by "Pan Jie (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pan Jie updated SHINDIG-1026:
-----------------------------

    Attachment: 20090421-2.patch

Here're what I did in this patch:
1. fix empty path warning message which will cause makeRequest failure and add an unittest to reproduce this issue.
2. change SigningFetcherTest->testFetchRequestForBodyHash to use example from OAuth Request Body Hash 1.0 Draft 4
3. remove BasicGadgetSpecFactory->fetcher
4. remove GadgetOAuthTokenStore::$SERVICE_NAME and other deprecated data member
5. add setStrictNoCache() and addIdentityParams() to OAuthFetcher for code reuse


> fix signing fetcher warning for empty path
> ------------------------------------------
>
>                 Key: SHINDIG-1026
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1026
>             Project: Shindig
>          Issue Type: Bug
>          Components: PHP
>    Affects Versions: trunk
>            Reporter: Pan Jie
>            Priority: Minor
>             Fix For: trunk
>
>         Attachments: 20090421-2.patch
>
>
> For empty path like http://example.org
> SigningFetcher will echo warning message because $parsedUri['path'] is null.
> So makeRequest will failed with this warning message.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.