You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Akash Gupta <ak...@hotmail.com> on 2017/11/27 17:45:31 UTC
Re: Review Request 63862: Windows: Ported docker_tests.cpp.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/
-----------------------------------------------------------
(Updated Nov. 27, 2017, 5:45 p.m.)
Review request for mesos, Andrew Schwartzmeyer and John Kordich.
Changes
-------
Rebased + addressed feedback. I also changed the image to use the nanserver image instead since it is 50x smaller. However, the nanoserver image doesn't work properly with volume mounts in process isolation mode, so I changed the mount tests to use hyper-v isolation, which works fine.
Summary (updated)
-----------------
Windows: Ported docker_tests.cpp.
Bugs: MESOS-7342
https://issues.apache.org/jira/browse/MESOS-7342
Repository: mesos
Description (updated)
-------
Ported the disabled tests to run on Windows. The following tests
could not be ported due to Windows platform limitations and remain
diabled:
- ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
sandbox).
- ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
- ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
Diffs (updated)
-----
src/tests/containerizer/docker_tests.cpp 5cabf5a0b0164f9923008677c58806c8931cbc8d
Diff: https://reviews.apache.org/r/63862/diff/2/
Changes: https://reviews.apache.org/r/63862/diff/1-2/
Testing (updated)
-------
Windows mesos-test:
[==========] 754 tests from 77 test cases ran. (270586 ms total)
[ PASSED ] 754 tests.
Windows DockerTest only:
[==========] 11 tests from 1 test case ran. (85617 ms total)
[ PASSED ] 11 tests.
Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia GPU):
[==========] 12 tests from 1 test case ran. (12413 ms total)
[ PASSED ] 12 tests.
Thanks,
Akash Gupta
Re: Review Request 63862: Windows: Ported docker_tests.cpp.
Posted by Akash Gupta <ak...@hotmail.com>.
> On Dec. 1, 2017, 2:33 a.m., Andrew Schwartzmeyer wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Lines 62 (patched)
> > <https://reviews.apache.org/r/63862/diff/2/?file=1901750#file1901750line62>
> >
> > We should probably comment as to why this doesn't use PowerShell (nanoserver image doesn't have it).
> >
> > Especially considering that `SLEEP_COMMAND` exists elsewhere, someone could easily assume they should change it.
>
> Akash Gupta wrote:
> There's a nanoserver image at `microsoft/powershell`. I can use that.
Added comment on why `SLEEP_COMMAND` can't be used.
> On Dec. 1, 2017, 2:33 a.m., Andrew Schwartzmeyer wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Lines 107-111 (patched)
> > <https://reviews.apache.org/r/63862/diff/2/?file=1901750#file1901750line107>
> >
> > Since this could end up being really slow and make the tests appear hung, I think we should `LOG(WARNING) << "Downloading Docker image...";` or something to that effect.
> >
> > (So much better than Hours(1) though.)
Added.
> On Dec. 1, 2017, 2:33 a.m., Andrew Schwartzmeyer wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Lines 121-128 (patched)
> > <https://reviews.apache.org/r/63862/diff/2/?file=1901750#file1901750line121>
> >
> > I see where this is quite useful, but perhaps the name could be a bit mores descriptive? I was thinking `from_root_dir` maybe?
Changed.
> On Dec. 1, 2017, 2:33 a.m., Andrew Schwartzmeyer wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Line 170 (original), 232-237 (patched)
> > <https://reviews.apache.org/r/63862/diff/2/?file=1901750#file1901750line232>
> >
> > Saw your reply explaining this on the review. I think we need to add a comment with the same explanation.
Yeah. Added an explanation
- Akash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review192436
-----------------------------------------------------------
On Dec. 7, 2017, 12:05 p.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2017, 12:05 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Jie Yu, John Kordich, and Joseph Wu.
>
>
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
> - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
> - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
> - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_tests.cpp 5cabf5a0b0164f9923008677c58806c8931cbc8d
>
>
> Diff: https://reviews.apache.org/r/63862/diff/3/
>
>
> Testing
> -------
>
> Windows mesos-test:
> [==========] 754 tests from 77 test cases ran. (270586 ms total)
> [ PASSED ] 754 tests.
>
>
> Windows DockerTest only:
> [==========] 11 tests from 1 test case ran. (85617 ms total)
> [ PASSED ] 11 tests.
>
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia GPU):
> [==========] 12 tests from 1 test case ran. (12413 ms total)
> [ PASSED ] 12 tests.
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 63862: Windows: Ported docker_tests.cpp.
Posted by Joseph Wu <jo...@mesosphere.io>.
> On Nov. 30, 2017, 6:33 p.m., Andrew Schwartzmeyer wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Line 318 (original), 391-428 (patched)
> > <https://reviews.apache.org/r/63862/diff/2/?file=1901750#file1901750line391>
> >
> > LGTM though another maintainer may want to take a look.
The current iteration of this this test (revision 5) looks fine. (Marking as Fixed)
- Joseph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review192436
-----------------------------------------------------------
On Jan. 5, 2018, 10:33 a.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2018, 10:33 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
> - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
> - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
> - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_tests.cpp 0ac4a79e03d5e11ead5a57a9749e26c20a1ddd57
>
>
> Diff: https://reviews.apache.org/r/63862/diff/5/
>
>
> Testing
> -------
>
> Windows mesos-test:
> [==========] 754 tests from 77 test cases ran. (270586 ms total)
> [ PASSED ] 754 tests.
>
>
> Windows DockerTest only:
> [==========] 11 tests from 1 test case ran. (85617 ms total)
> [ PASSED ] 11 tests.
>
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia GPU):
> [==========] 12 tests from 1 test case ran. (12413 ms total)
> [ PASSED ] 12 tests.
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 63862: Windows: Ported docker_tests.cpp.
Posted by Akash Gupta <ak...@hotmail.com>.
> On Dec. 1, 2017, 2:33 a.m., Andrew Schwartzmeyer wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Lines 62 (patched)
> > <https://reviews.apache.org/r/63862/diff/2/?file=1901750#file1901750line62>
> >
> > We should probably comment as to why this doesn't use PowerShell (nanoserver image doesn't have it).
> >
> > Especially considering that `SLEEP_COMMAND` exists elsewhere, someone could easily assume they should change it.
There's a nanoserver image at `microsoft/powershell`. I can use that.
> On Dec. 1, 2017, 2:33 a.m., Andrew Schwartzmeyer wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Lines 63 (patched)
> > <https://reviews.apache.org/r/63862/diff/2/?file=1901750#file1901750line63>
> >
> > Is this the canonical path it should use on Windows? Seems like we could choose an arbitrary path.
It's an arbitrary path. I just chose it because the Linux test uses `/mnt/sandbox/mesos`
- Akash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review192436
-----------------------------------------------------------
On Dec. 1, 2017, 2:34 a.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2017, 2:34 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Jie Yu, John Kordich, and Joseph Wu.
>
>
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
> - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
> - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
> - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_tests.cpp 5cabf5a0b0164f9923008677c58806c8931cbc8d
>
>
> Diff: https://reviews.apache.org/r/63862/diff/2/
>
>
> Testing
> -------
>
> Windows mesos-test:
> [==========] 754 tests from 77 test cases ran. (270586 ms total)
> [ PASSED ] 754 tests.
>
>
> Windows DockerTest only:
> [==========] 11 tests from 1 test case ran. (85617 ms total)
> [ PASSED ] 11 tests.
>
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia GPU):
> [==========] 12 tests from 1 test case ran. (12413 ms total)
> [ PASSED ] 12 tests.
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 63862: Windows: Ported docker_tests.cpp.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review192436
-----------------------------------------------------------
src/tests/containerizer/docker_tests.cpp
Lines 62 (patched)
<https://reviews.apache.org/r/63862/#comment270582>
We should probably comment as to why this doesn't use PowerShell (nanoserver image doesn't have it).
Especially considering that `SLEEP_COMMAND` exists elsewhere, someone could easily assume they should change it.
src/tests/containerizer/docker_tests.cpp
Lines 63 (patched)
<https://reviews.apache.org/r/63862/#comment270583>
Is this the canonical path it should use on Windows? Seems like we could choose an arbitrary path.
src/tests/containerizer/docker_tests.cpp
Lines 107-111 (patched)
<https://reviews.apache.org/r/63862/#comment270584>
Since this could end up being really slow and make the tests appear hung, I think we should `LOG(WARNING) << "Downloading Docker image...";` or something to that effect.
(So much better than Hours(1) though.)
src/tests/containerizer/docker_tests.cpp
Lines 121-128 (patched)
<https://reviews.apache.org/r/63862/#comment270593>
I see where this is quite useful, but perhaps the name could be a bit mores descriptive? I was thinking `from_root_dir` maybe?
src/tests/containerizer/docker_tests.cpp
Line 170 (original), 232-237 (patched)
<https://reviews.apache.org/r/63862/#comment270585>
Saw your reply explaining this on the review. I think we need to add a comment with the same explanation.
src/tests/containerizer/docker_tests.cpp
Line 318 (original), 391-428 (patched)
<https://reviews.apache.org/r/63862/#comment270591>
LGTM though another maintainer may want to take a look.
src/tests/containerizer/docker_tests.cpp
Lines 624-630 (patched)
<https://reviews.apache.org/r/63862/#comment270592>
Ah the woes of new technology.
- Andrew Schwartzmeyer
On Nov. 27, 2017, 9:45 a.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2017, 9:45 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and John Kordich.
>
>
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
> - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
> - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
> - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_tests.cpp 5cabf5a0b0164f9923008677c58806c8931cbc8d
>
>
> Diff: https://reviews.apache.org/r/63862/diff/2/
>
>
> Testing
> -------
>
> Windows mesos-test:
> [==========] 754 tests from 77 test cases ran. (270586 ms total)
> [ PASSED ] 754 tests.
>
>
> Windows DockerTest only:
> [==========] 11 tests from 1 test case ran. (85617 ms total)
> [ PASSED ] 11 tests.
>
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia GPU):
> [==========] 12 tests from 1 test case ran. (12413 ms total)
> [ PASSED ] 12 tests.
>
>
> Thanks,
>
> Akash Gupta
>
>