You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Knut Anders Hatlen (JIRA)" <ji...@apache.org> on 2012/04/24 12:53:33 UTC
[jira] [Created] (DERBY-5707) Clean up statements in CharUTF8Test
Knut Anders Hatlen created DERBY-5707:
-----------------------------------------
Summary: Clean up statements in CharUTF8Test
Key: DERBY-5707
URL: https://issues.apache.org/jira/browse/DERBY-5707
Project: Derby
Issue Type: Improvement
Components: Test
Affects Versions: 10.9.0.0
Reporter: Knut Anders Hatlen
Assignee: Knut Anders Hatlen
Priority: Minor
CharUTF8Test has two PreparedStatement fields. The statements are closed in tearDown(), but not nulled out. We should null out the references to let the statements be garbage collected.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (DERBY-5707) Clean up statements in CharUTF8Test
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen closed DERBY-5707.
-------------------------------------
Resolution: Fixed
Fix Version/s: 10.9.0.0
Issue & fix info: (was: Patch Available)
> Clean up statements in CharUTF8Test
> -----------------------------------
>
> Key: DERBY-5707
> URL: https://issues.apache.org/jira/browse/DERBY-5707
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Affects Versions: 10.9.0.0
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Priority: Minor
> Fix For: 10.9.0.0
>
> Attachments: d5707-1a.diff, d5707-1b.diff
>
>
> CharUTF8Test has two PreparedStatement fields. The statements are closed in tearDown(), but not nulled out. We should null out the references to let the statements be garbage collected.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5707) Clean up statements in CharUTF8Test
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260460#comment-13260460 ]
Kristian Waagan commented on DERBY-5707:
----------------------------------------
+1
If you want to, you can also delete this line (unused variable):
int off = 0;
> Clean up statements in CharUTF8Test
> -----------------------------------
>
> Key: DERBY-5707
> URL: https://issues.apache.org/jira/browse/DERBY-5707
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Affects Versions: 10.9.0.0
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Priority: Minor
> Attachments: d5707-1a.diff
>
>
> CharUTF8Test has two PreparedStatement fields. The statements are closed in tearDown(), but not nulled out. We should null out the references to let the statements be garbage collected.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5707) Clean up statements in CharUTF8Test
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen updated DERBY-5707:
--------------------------------------
Issue & fix info: Patch Available
> Clean up statements in CharUTF8Test
> -----------------------------------
>
> Key: DERBY-5707
> URL: https://issues.apache.org/jira/browse/DERBY-5707
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Affects Versions: 10.9.0.0
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Priority: Minor
> Attachments: d5707-1a.diff
>
>
> CharUTF8Test has two PreparedStatement fields. The statements are closed in tearDown(), but not nulled out. We should null out the references to let the statements be garbage collected.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5707) Clean up statements in CharUTF8Test
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen updated DERBY-5707:
--------------------------------------
Attachment: d5707-1a.diff
The attached patch makes tearDown() null out the references to the statements instead of closing them. (They will still be closed in super.tearDown().) Also fix a typo in a javadoc comment.
> Clean up statements in CharUTF8Test
> -----------------------------------
>
> Key: DERBY-5707
> URL: https://issues.apache.org/jira/browse/DERBY-5707
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Affects Versions: 10.9.0.0
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Priority: Minor
> Attachments: d5707-1a.diff
>
>
> CharUTF8Test has two PreparedStatement fields. The statements are closed in tearDown(), but not nulled out. We should null out the references to let the statements be garbage collected.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5707) Clean up statements in CharUTF8Test
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen updated DERBY-5707:
--------------------------------------
Attachment: d5707-1b.diff
Thanks, Kristian. I've updated the patch as suggested.
Committed revision 1329686.
> Clean up statements in CharUTF8Test
> -----------------------------------
>
> Key: DERBY-5707
> URL: https://issues.apache.org/jira/browse/DERBY-5707
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Affects Versions: 10.9.0.0
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Priority: Minor
> Attachments: d5707-1a.diff, d5707-1b.diff
>
>
> CharUTF8Test has two PreparedStatement fields. The statements are closed in tearDown(), but not nulled out. We should null out the references to let the statements be garbage collected.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira