[GitHub] [arrow] vertexclique commented on a change in pull request #7917: ARROW-8243: [Rust] [Parquet] Serialize Arrow schema metadata

[GitBox <gi...@apache.org>]

vertexclique commented on a change in pull request #7917:
URL: https://github.com/apache/arrow/pull/7917#discussion_r467496882



##########
File path: rust/parquet/Cargo.toml
##########
@@ -52,4 +53,4 @@ zstd = "0.5"
 arrow = { path = "../arrow", version = "2.0.0-SNAPSHOT" }
 
 [features]
-default = ["arrow", "snap", "brotli", "flate2", "lz4", "zstd"]
+default = ["arrow", "snap", "brotli", "flate2", "lz4", "zstd", "base64"]

Review comment:
       Would be super nice. Meanwhile I was looking to parquet in [this PR](https://github.com/apache/arrow/pull/7873) I realized that `"snap", "brotli", "flate2", "lz4", "zstd"` part is not always needed. Since these compressions are not additive features(I am not sure, we might need to check this).
   
   What about a feature gating like this? wdyt?:
   ```
   default = ["core"]
   core = ["arrow", "base64"]
   all = ["arrow", "snap", "brotli", "flate2", "lz4", "zstd", "base64"]
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org