[jira] [Commented] (FLINK-7952) Add metrics for counting logging events

["Chesnay Schepler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360646#comment-16360646 ] 

Chesnay Schepler commented on FLINK-7952:
-----------------------------------------

I question the value of having this counter as part of Flink.

As i understand it we wouldn't be able to plug these into the metric system (without reflection/static access), which severely limits the visibility.

Furthermore, why actually have this as part of the Flink project? This is perfect for a small self-contained project. There's nothing Flink-specific in there, in fact the only reason why you can't use the Hadoop EventCounter with Flink is that they have annotated it with their annotations.

> Add metrics for counting logging events 
> ----------------------------------------
>
>                 Key: FLINK-7952
>                 URL: https://issues.apache.org/jira/browse/FLINK-7952
>             Project: Flink
>          Issue Type: Wish
>          Components: Metrics
>    Affects Versions: 1.4.0
>            Reporter: Hai Zhou UTC+8
>            Assignee: Hai Zhou UTC+8
>            Priority: Critical
>             Fix For: 1.5.0
>
>
> It would be useful to track logging events .
> *impl:*
> adds event counting via a custom Log4J Appender, this tracks the number of INFO, WARN, ERROR and FATAL logging events.
> *ref:*
> hadoop-common: [org.apache.hadoop.log.metrics. EventCounter |https://github.com/apache/hadoop/blob/f67237cbe7bc48a1b9088e990800b37529f1db2a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/log/metrics/EventCounter.java]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)