You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Eric Covener <co...@gmail.com> on 2014/12/06 15:44:40 UTC

Re: svn commit: r1643537 - in /httpd/httpd/trunk: CHANGES docs/log-message-tags/next-number modules/proxy/mod_proxy_ajp.c

On Sat, Dec 6, 2014 at 9:33 AM,  <yl...@apache.org> wrote:
> +    else if (output_failed) {
> +        ap_log_rerror(APLOG_MARK, APLOG_ERR, status, r, APLOGNO(02822)
> +                      "dialog with client %pI failed",
> +                      r->connection->client_addr);
> +        if (rv == OK) {
> +            rv = HTTP_BAD_REQUEST;
> +        }
> +    }

>From memory/spot-checking, I think this would make c->aborted errors
noisier when they happen to be handled by proxy_ajp.




-- 
Eric Covener
covener@gmail.com

Re: svn commit: r1643537 - in /httpd/httpd/trunk: CHANGES docs/log-message-tags/next-number modules/proxy/mod_proxy_ajp.c

Posted by Yann Ylavic <yl...@gmail.com>.
On Sat, Dec 6, 2014 at 3:44 PM, Eric Covener <co...@gmail.com> wrote:
> On Sat, Dec 6, 2014 at 9:33 AM,  <yl...@apache.org> wrote:
>> +    else if (output_failed) {
>> +        ap_log_rerror(APLOG_MARK, APLOG_ERR, status, r, APLOGNO(02822)
>> +                      "dialog with client %pI failed",
>> +                      r->connection->client_addr);
>> +        if (rv == OK) {
>> +            rv = HTTP_BAD_REQUEST;
>> +        }
>> +    }
>
> From memory/spot-checking, I think this would make c->aborted errors
> noisier when they happen to be handled by proxy_ajp.

Agreed, fixed in r1643543.

Thanks,
Yann.