You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/25 06:43:51 UTC

[GitHub] [spark] LuciferYang commented on a change in pull request #32232: [SPARK-35135][CORE] Turn the `WritablePartitionedIterator` from a trait into a default implementation class

LuciferYang commented on a change in pull request #32232:
URL: https://github.com/apache/spark/pull/32232#discussion_r619760870



##########
File path: core/src/main/scala/org/apache/spark/util/collection/WritablePartitionedPairCollection.scala
##########
@@ -94,3 +83,20 @@ private[spark] trait WritablePartitionedIterator {
 
   def nextPartition(): Int
 }
+
+/**
+ * Default implementation of `WritablePartitionedIterator`.
+ */
+private[spark] class DefaultWritablePartitionedIterator[K, V](it: Iterator[((Int, K), V)])

Review comment:
       8835ecc add a `IncompatibleTemplateDefProblem` exclude filter to `MimaExcludes.scala`, GA passed now. @Ngone51 @HyukjinKwon 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org