[GitHub] [arrow-rs] alamb commented on a change in pull request #1320: fix test bug and cc metadata to_thrift

[GitBox <gi...@apache.org>]

alamb commented on a change in pull request #1320:
URL: https://github.com/apache/arrow-rs/pull/1320#discussion_r807864414



##########
File path: parquet/src/file/metadata.rs
##########
@@ -533,7 +533,7 @@ impl ColumnChunkMetaData {
             dictionary_page_offset: self.dictionary_page_offset,
             statistics: statistics::to_thrift(self.statistics.as_ref()),
             encoding_stats: None,
-            bloom_filter_offset: None,
+            bloom_filter_offset: self.bloom_filter_offset,

Review comment:
       👍 

##########
File path: parquet/src/file/metadata.rs
##########
@@ -739,17 +739,15 @@ mod tests {
             .set_total_uncompressed_size(3000)
             .set_data_page_offset(4000)
             .set_dictionary_page_offset(Some(5000))
+            .set_bloom_filter_offset(Some(6000))
             .build()
             .unwrap();
 
-        let col_chunk_exp = col_metadata.to_thrift();
-
         let col_chunk_res =
-            ColumnChunkMetaData::from_thrift(column_descr, col_chunk_exp.clone())
-                .unwrap()
-                .to_thrift();
+            ColumnChunkMetaData::from_thrift(column_descr, col_metadata.to_thrift())
+                .unwrap();
 
-        assert_eq!(col_chunk_res, col_chunk_exp);
+        assert_eq!(col_chunk_res, col_metadata);

Review comment:
       I thought a little about if there was any value it keeping the check that `col_chunk_res.to_thrift()` and `col_metadata.to_thrift()` were also equal, but I think that given that this PR is deriving `PartialEq` on `ColumnChunkMetadata` there is no extra value in comparing the thrift serialized version  




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org