You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by al...@apache.org on 2007/06/19 19:30:04 UTC
svn commit: r548803 -
/incubator/wicket/trunk/jdk-1.4/wicket-spring/src/main/java/org/apache/wicket/injection/Injector.java
Author: almaw
Date: Tue Jun 19 10:30:03 2007
New Revision: 548803
URL: http://svn.apache.org/viewvc?view=rev&rev=548803
Log:
Add FIXME for WICKET-625.
Modified:
incubator/wicket/trunk/jdk-1.4/wicket-spring/src/main/java/org/apache/wicket/injection/Injector.java
Modified: incubator/wicket/trunk/jdk-1.4/wicket-spring/src/main/java/org/apache/wicket/injection/Injector.java
URL: http://svn.apache.org/viewvc/incubator/wicket/trunk/jdk-1.4/wicket-spring/src/main/java/org/apache/wicket/injection/Injector.java?view=diff&rev=548803&r1=548802&r2=548803
==============================================================================
--- incubator/wicket/trunk/jdk-1.4/wicket-spring/src/main/java/org/apache/wicket/injection/Injector.java (original)
+++ incubator/wicket/trunk/jdk-1.4/wicket-spring/src/main/java/org/apache/wicket/injection/Injector.java Tue Jun 19 10:30:03 2007
@@ -27,7 +27,6 @@
import org.apache.wicket.markup.html.panel.Panel;
import org.apache.wicket.util.concurrent.ConcurrentHashMap;
-
/**
* Injector scans fields of an object instance and checks if the specified
* {@link IFieldValueFactory} can provide a value for a field; if it can, the
@@ -40,6 +39,8 @@
{
private static Injector instance = new Injector();
+ // FIXME: WICKET-625 - Wicket doesn't clean up properly when hot-deploying; hangs onto Class references.
+ // We need some way to clean out this hashmap when we're done.
private ConcurrentHashMap/* <Class, Field[]> */classToFields = new ConcurrentHashMap();
/**
@@ -83,9 +84,7 @@
public Object inject(Object object, IFieldValueFactory factory)
{
Class clazz = object.getClass();
- Field[] fields;
-
- fields = (Field[]) classToFields.get(clazz);
+ Field[] fields = (Field[]) classToFields.get(clazz);
if (fields == null)
{
fields = findFields(clazz, factory);