You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Jun Rao (Created) (JIRA)" <ji...@apache.org> on 2012/02/29 02:04:05 UTC
[jira] [Created] (KAFKA-290) use propertyExists to test if both
broker.list and zk.connect are present
use propertyExists to test if both broker.list and zk.connect are present
-------------------------------------------------------------------------
Key: KAFKA-290
URL: https://issues.apache.org/jira/browse/KAFKA-290
Project: Kafka
Issue Type: Improvement
Reporter: Jun Rao
Assignee: Jun Rao
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-290) use propertyExists to test if both
broker.list and zk.connect are present
Posted by "Jun Rao (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jun Rao updated KAFKA-290:
--------------------------
Attachment: kafka-290_v2.patch
Attach patch v2.
> use propertyExists to test if both broker.list and zk.connect are present
> -------------------------------------------------------------------------
>
> Key: KAFKA-290
> URL: https://issues.apache.org/jira/browse/KAFKA-290
> Project: Kafka
> Issue Type: Improvement
> Affects Versions: 0.7.1
> Reporter: Jun Rao
> Assignee: Jun Rao
> Attachments: kafka-290.patch, kafka-290_v2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-290) use propertyExists to test if both
broker.list and zk.connect are present
Posted by "Neha Narkhede (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218844#comment-13218844 ]
Neha Narkhede commented on KAFKA-290:
-------------------------------------
+1 on v3.
> use propertyExists to test if both broker.list and zk.connect are present
> -------------------------------------------------------------------------
>
> Key: KAFKA-290
> URL: https://issues.apache.org/jira/browse/KAFKA-290
> Project: Kafka
> Issue Type: Improvement
> Affects Versions: 0.7.1
> Reporter: Jun Rao
> Assignee: Jun Rao
> Attachments: kafka-290.patch, kafka-290_v2.patch, kafka-290_v3.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-290) use propertyExists to test if both
broker.list and zk.connect are present
Posted by "Jun Rao (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jun Rao updated KAFKA-290:
--------------------------
Attachment: kafka-290.patch
> use propertyExists to test if both broker.list and zk.connect are present
> -------------------------------------------------------------------------
>
> Key: KAFKA-290
> URL: https://issues.apache.org/jira/browse/KAFKA-290
> Project: Kafka
> Issue Type: Improvement
> Reporter: Jun Rao
> Assignee: Jun Rao
> Attachments: kafka-290.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-290) use propertyExists to test if both
broker.list and zk.connect are present
Posted by "Neha Narkhede (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218792#comment-13218792 ]
Neha Narkhede commented on KAFKA-290:
-------------------------------------
There is another place where it will be worthwhile to use propertyExists instead of a non-null check -
if(brokerList != null && Utils.getString(props, "partitioner.class", null) != null)
throw new InvalidConfigException("partitioner.class cannot be used when broker.list is set")
> use propertyExists to test if both broker.list and zk.connect are present
> -------------------------------------------------------------------------
>
> Key: KAFKA-290
> URL: https://issues.apache.org/jira/browse/KAFKA-290
> Project: Kafka
> Issue Type: Improvement
> Affects Versions: 0.7.1
> Reporter: Jun Rao
> Assignee: Jun Rao
> Attachments: kafka-290.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-290) use propertyExists to test if both
broker.list and zk.connect are present
Posted by "Jun Rao (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jun Rao updated KAFKA-290:
--------------------------
Attachment: kafka-290_v3.patch
Attach patch v3 that requires either broker.lost or zk.connect to be present. Have to patch some unit tests that don't specify either broker.list or zk.connect in ProducerConfig.
> use propertyExists to test if both broker.list and zk.connect are present
> -------------------------------------------------------------------------
>
> Key: KAFKA-290
> URL: https://issues.apache.org/jira/browse/KAFKA-290
> Project: Kafka
> Issue Type: Improvement
> Affects Versions: 0.7.1
> Reporter: Jun Rao
> Assignee: Jun Rao
> Attachments: kafka-290.patch, kafka-290_v2.patch, kafka-290_v3.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-290) use propertyExists to test if both
broker.list and zk.connect are present
Posted by "Neha Narkhede (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Neha Narkhede updated KAFKA-290:
--------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Fix exists in trunk
> use propertyExists to test if both broker.list and zk.connect are present
> -------------------------------------------------------------------------
>
> Key: KAFKA-290
> URL: https://issues.apache.org/jira/browse/KAFKA-290
> Project: Kafka
> Issue Type: Improvement
> Affects Versions: 0.7.1
> Reporter: Jun Rao
> Assignee: Jun Rao
> Attachments: kafka-290.patch, kafka-290_v2.patch, kafka-290_v3.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-290) use propertyExists to test if both
broker.list and zk.connect are present
Posted by "Neha Narkhede (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218826#comment-13218826 ]
Neha Narkhede commented on KAFKA-290:
-------------------------------------
But, I think the check for both properties absent, should also be there, right ?
> use propertyExists to test if both broker.list and zk.connect are present
> -------------------------------------------------------------------------
>
> Key: KAFKA-290
> URL: https://issues.apache.org/jira/browse/KAFKA-290
> Project: Kafka
> Issue Type: Improvement
> Affects Versions: 0.7.1
> Reporter: Jun Rao
> Assignee: Jun Rao
> Attachments: kafka-290.patch, kafka-290_v2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-290) use propertyExists to test if both
broker.list and zk.connect are present
Posted by "Jun Rao (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jun Rao updated KAFKA-290:
--------------------------
Affects Version/s: 0.7.1
Status: Patch Available (was: Open)
patch attached.
> use propertyExists to test if both broker.list and zk.connect are present
> -------------------------------------------------------------------------
>
> Key: KAFKA-290
> URL: https://issues.apache.org/jira/browse/KAFKA-290
> Project: Kafka
> Issue Type: Improvement
> Affects Versions: 0.7.1
> Reporter: Jun Rao
> Assignee: Jun Rao
> Attachments: kafka-290.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira