[GitHub] [airflow] hussein-awala commented on a diff in pull request #32569: Fix a bug in the ShortCircuitOperator

["hussein-awala (via GitHub)" <gi...@apache.org>]

hussein-awala commented on code in PR #32569:
URL: https://github.com/apache/airflow/pull/32569#discussion_r1261778712


##########
tests/operators/test_python.py:
##########
@@ -617,7 +617,7 @@ def test_xcom_push(self):
 
         tis = dr.get_task_instances()
         assert tis[0].xcom_pull(task_ids=short_op_push_xcom.task_id, key="return_value") == "signature"
-        assert tis[0].xcom_pull(task_ids=short_op_no_push_xcom.task_id, key="return_value") is None
+        assert tis[0].xcom_pull(task_ids=short_op_no_push_xcom.task_id, key="return_value") is False

Review Comment:
   Is this considered a breaking change? If yes, how do you think we can handle it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org