[GitHub] [incubator-shardingsphere] KomachiSion commented on a change in pull request #3392: Add tomcat dbcp2 custom connection-properties support

[GitBox <gi...@apache.org>]

KomachiSion commented on a change in pull request #3392: Add tomcat dbcp2 custom connection-properties support
URL: https://github.com/apache/incubator-shardingsphere/pull/3392#discussion_r339911600
 
 

 ##########
 File path: sharding-spring/sharding-spring-boot-util/src/main/java/org/apache/shardingsphere/spring/boot/datasource/AbstractDbcp2DataSourcePropertiesSetter.java
 ##########
 @@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.spring.boot.datasource;
+
+import lombok.SneakyThrows;
+import org.apache.shardingsphere.spring.boot.util.PropertyUtil;
+import org.springframework.core.env.Environment;
+
+import javax.sql.DataSource;
+import java.lang.reflect.Method;
+import java.util.Map;
+
+/**
+ * DBCP datasource properties setter.
+ *
+ * @author xiayan
+ */
+public abstract class AbstractDbcp2DataSourcePropertiesSetter implements DataSourcePropertiesSetter {
+    
+    /**
+     * common dbcp2 add custom connection properties.
+     *
+     * @param environment environment variable
+     * @param prefix properties prefix
+     * @param dataSourceName current database name
+     * @param dataSource dataSource instance
+     */
+    @SneakyThrows(ReflectiveOperationException.class)
+    public void propertiesSet(final Environment environment, final String prefix, final String dataSourceName, final DataSource dataSource) {
+        String datasourcePropertiesPrefix = prefix + dataSourceName.trim() + ".connection-properties";
+        if (PropertyUtil.containPropertyPrefix(environment, datasourcePropertiesPrefix)) {
+            Map datasourceProperties = PropertyUtil.handle(environment, datasourcePropertiesPrefix, Map.class);
+            Method method = dataSource.getClass().getMethod("addConnectionProperty", String.class, String.class);
+            for (Object key : datasourceProperties.keySet()) {
 
 Review comment:
   use `each` as the item in for-each loop.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services