You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by kunal642 <gi...@git.apache.org> on 2018/01/02 10:08:25 UTC
[GitHub] carbondata pull request #1747: [Compatibility] Added changes for backward co...
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1747
[Compatibility] Added changes for backward compatibility
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kunal642/carbondata upgrade_support
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1747.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1747
----
commit bab3fd7ef50073fa951daf8150f9f98dc6e1c813
Author: kunal642 <ku...@...>
Date: 2017-11-20T15:06:54Z
added changes for backward compatibility
----
---
[GitHub] carbondata issue #1747: [Compatibility] Added changes for backward compatibi...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1747
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1295/
---
[GitHub] carbondata issue #1747: [Compatibility] Added changes for backward compatibi...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1747
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2512/
---
[GitHub] carbondata pull request #1747: [Compatibility] Added changes for backward co...
Posted by manishgupta88 <gi...@git.apache.org>.
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1747#discussion_r159589266
--- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CarbonScalaUtil.scala ---
@@ -291,4 +291,52 @@ object CarbonScalaUtil {
})
otherFields
}
+
+ /**
+ * If the table is from an old store then the table parameters are in lowercase. In the current
+ * code we are reading the parameters as camel case.
+ * This method will convert all the schema parts to camel case
+ *
+ * @param parameters
+ * @return
+ */
+ def getDeserializedParameters(parameters: Map[String, String]): Map[String, String] = {
--- End diff --
there is no calling point for this method
---
[GitHub] carbondata pull request #1747: [Compatibility] Added changes for backward co...
Posted by manishgupta88 <gi...@git.apache.org>.
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1747#discussion_r159589331
--- Diff: core/src/main/java/org/apache/carbondata/core/util/path/CarbonTablePath.java ---
@@ -231,7 +231,22 @@ public String getSchemaFilePath() {
* @return schema file path
*/
public static String getSchemaFilePath(String tablePath) {
- return tablePath + File.separator + METADATA_DIR + File.separator + SCHEMA_FILE;
+ return getActualSchemaFilePath(tablePath);
+ }
+
+ private static String getActualSchemaFilePath(String tablePath) {
+ String metaPath = tablePath + File.separator + METADATA_DIR;
--- End diff --
use CarbonCommonConstants.FILE_SEPARATOR instead of File.separator
---
[GitHub] carbondata issue #1747: [Compatibility] Added changes for backward compatibi...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1747
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2479/
---
[GitHub] carbondata issue #1747: [Compatibility] Added changes for backward compatibi...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1747
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2664/
---
[GitHub] carbondata pull request #1747: [Compatibility] Added changes for backward co...
Posted by manishgupta88 <gi...@git.apache.org>.
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1747#discussion_r159589250
--- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CarbonScalaUtil.scala ---
@@ -291,4 +291,52 @@ object CarbonScalaUtil {
})
otherFields
}
+
+ /**
+ * If the table is from an old store then the table parameters are in lowercase. In the current
+ * code we are reading the parameters as camel case.
+ * This method will convert all the schema parts to camel case
+ *
+ * @param parameters
+ * @return
+ */
+ def getDeserializedParameters(parameters: Map[String, String]): Map[String, String] = {
+ val keyParts = parameters.getOrElse("spark.sql.sources.options.keys.numparts", "0").toInt
+ if (keyParts == 0) {
+ parameters
+ } else {
+ var keyStr = ""
+ for(i <- 0 until keyParts) {
+ keyStr += parameters(s"spark.sql.sources.options.keys.part.$i")
+ }
+ val finalProperties = scala.collection.mutable.Map.empty[String, String]
+ keyStr.split(",") foreach {
--- End diff --
Please check the logic here. Keystr is not appended explicitly with , but splitting is done based on comma
---
[GitHub] carbondata pull request #1747: [Compatibility] Added changes for backward co...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1747
---
[GitHub] carbondata issue #1747: [Compatibility] Added changes for backward compatibi...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1747
Please add description for this PR
---
[GitHub] carbondata issue #1747: [Compatibility] Added changes for backward compatibi...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1747
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3221/
---
[GitHub] carbondata issue #1747: [Compatibility] Added changes for backward compatibi...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1747
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2499/
---
[GitHub] carbondata issue #1747: [Compatibility] Added changes for backward compatibi...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1747
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2680/
---
[GitHub] carbondata issue #1747: [Compatibility] Added changes for backward compatibi...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1747
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1275/
---
[GitHub] carbondata issue #1747: [Compatibility] Added changes for backward compatibi...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1747
Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1255/
---
[GitHub] carbondata issue #1747: [Compatibility] Added changes for backward compatibi...
Posted by manishgupta88 <gi...@git.apache.org>.
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1747
LGTM
---
[GitHub] carbondata issue #1747: [Compatibility] Added changes for backward compatibi...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1747
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1987/
---
[GitHub] carbondata issue #1747: [Compatibility] Added changes for backward compatibi...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1747
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3181/
---