[GitHub] [incubator-superset] ktmud commented on a change in pull request #10507: docs: new contributing language around adding new plugins

[GitBox <gi...@apache.org>]

ktmud commented on a change in pull request #10507:
URL: https://github.com/apache/incubator-superset/pull/10507#discussion_r464670620



##########
File path: CONTRIBUTING.md
##########
@@ -814,7 +814,7 @@ Then, [extract strings for the new language](#extracting-new-strings-for-transla
 
 ### Improving visualizations
 
-Superset is working towards a plugin system where new visualizations can be installed as optional npm packages. To achieve this goal, we are not accepting pull requests for new community-contributed visualization types at the moment. However, bugfixes for current visualizations are welcome. To edit the frontend code for visualizations, you will have to check out a copy of [apache-superset/superset-ui](https://github.com/apache-superset/superset-ui):
+Bugfixes for core visualizations are welcome. To edit the frontend code for visualizations, you will have to check out a copy of [apache-superset/superset-ui](https://github.com/apache-superset/superset-ui):

Review comment:
       ```suggestion
   To edit the frontend code for visualizations, you will have to check out a copy of [apache-superset/superset-ui](https://github.com/apache-superset/superset-ui):
   ```
   
   The language about bugfixes doesn't seem necessary, either. Plus the improvements can be more than bugfixes.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org