You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2018/03/02 08:07:35 UTC
Re: Review Request 63992: Handled incorrect offer operation IDs in
master's ACCEPT handler.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63992/
-----------------------------------------------------------
(Updated March 2, 2018, 8:07 a.m.)
Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu.
Changes
-------
Rebase.
Bugs: MESOS-8190
https://issues.apache.org/jira/browse/MESOS-8190
Repository: mesos
Description (updated)
-------
This patch adds code to send operation status updates in the master's
ACCEPT call handler. In cases where operations are dropped and in
cases where offer operation IDs are set when they should not be, the
master will send operation status updates for the dropped operations.
Diffs (updated)
-----
src/master/master.cpp 9cea7bb6a6ee8bf5f4226d07111bcfa6f5d3a88c
Diff: https://reviews.apache.org/r/63992/diff/2/
Changes: https://reviews.apache.org/r/63992/diff/1-2/
Testing
-------
make check
Thanks,
Greg Mann
Re: Review Request 63992: Handled incorrect offer operation IDs in
master's ACCEPT handler.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63992/#review198558
-----------------------------------------------------------
Ship it!
- Gaston Kleiman
On March 2, 2018, 12:07 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63992/
> -----------------------------------------------------------
>
> (Updated March 2, 2018, 12:07 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu.
>
>
> Bugs: MESOS-8190
> https://issues.apache.org/jira/browse/MESOS-8190
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds code to send operation status updates in the master's
> ACCEPT call handler. In cases where operations are dropped and in
> cases where offer operation IDs are set when they should not be, the
> master will send operation status updates for the dropped operations.
>
>
> Diffs
> -----
>
> src/master/master.cpp 9cea7bb6a6ee8bf5f4226d07111bcfa6f5d3a88c
>
>
> Diff: https://reviews.apache.org/r/63992/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 63992: Handled incorrect offer operation IDs in
master's ACCEPT handler.
Posted by Greg Mann <gr...@mesosphere.io>.
> On March 14, 2018, 3:55 p.m., Benjamin Bannier wrote:
> > I am confused why this patch does not add a status update manager for master-generated operation status updates. Right now there is no way for frameworks to e.g., reconcile failed operations after framework failover since the master does not remember any operation status updates in generated (in addition to not retrying their delivery).
> >
> > Apart from that the changes seem to do what they advertise, but I wonder whether now would be the right time to address the numerous `TOOD`s, e.g., the one about adding a helper to encapsulate the code around `drop`ped operations. I am pretty sure this will be useful in the future.
We're following the pattern we have already for task status updates, and not requiring acknowledgement for master-generated operation status updates. If the framework attempts to reconcile such an operation, it will indeed be unknown. I think that adding a status update manager to the master for this purpose alone introduces more complexity than it's worth. It seems to have worked fine thus far for tasks?
I think that adding the `drop` overload could be done in a separate patch.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63992/#review199172
-----------------------------------------------------------
On March 13, 2018, 9:49 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63992/
> -----------------------------------------------------------
>
> (Updated March 13, 2018, 9:49 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu.
>
>
> Bugs: MESOS-8190
> https://issues.apache.org/jira/browse/MESOS-8190
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds code to send operation status updates in the master's
> ACCEPT call handler. In cases where operations are dropped and in
> cases where offer operation IDs are set when they should not be, the
> master will send operation status updates for the dropped operations.
>
>
> Diffs
> -----
>
> src/master/master.cpp 223ebf29ac4dd1dea9080e4bef4b2d4d064d847f
>
>
> Diff: https://reviews.apache.org/r/63992/diff/5/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 63992: Handled incorrect offer operation IDs in
master's ACCEPT handler.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63992/#review199172
-----------------------------------------------------------
I am confused why this patch does not add a status update manager for master-generated operation status updates. Right now there is no way for frameworks to e.g., reconcile failed operations after framework failover since the master does not remember any operation status updates in generated (in addition to not retrying their delivery).
Apart from that the changes seem to do what they advertise, but I wonder whether now would be the right time to address the numerous `TOOD`s, e.g., the one about adding a helper to encapsulate the code around `drop`ped operations. I am pretty sure this will be useful in the future.
- Benjamin Bannier
On March 13, 2018, 10:49 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63992/
> -----------------------------------------------------------
>
> (Updated March 13, 2018, 10:49 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu.
>
>
> Bugs: MESOS-8190
> https://issues.apache.org/jira/browse/MESOS-8190
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds code to send operation status updates in the master's
> ACCEPT call handler. In cases where operations are dropped and in
> cases where offer operation IDs are set when they should not be, the
> master will send operation status updates for the dropped operations.
>
>
> Diffs
> -----
>
> src/master/master.cpp 223ebf29ac4dd1dea9080e4bef4b2d4d064d847f
>
>
> Diff: https://reviews.apache.org/r/63992/diff/5/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 63992: Handled incorrect offer operation IDs in
master's ACCEPT handler.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63992/#review199124
-----------------------------------------------------------
Ship it!
Ship It!
- Gaston Kleiman
On March 13, 2018, 2:49 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63992/
> -----------------------------------------------------------
>
> (Updated March 13, 2018, 2:49 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu.
>
>
> Bugs: MESOS-8190
> https://issues.apache.org/jira/browse/MESOS-8190
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds code to send operation status updates in the master's
> ACCEPT call handler. In cases where operations are dropped and in
> cases where offer operation IDs are set when they should not be, the
> master will send operation status updates for the dropped operations.
>
>
> Diffs
> -----
>
> src/master/master.cpp 223ebf29ac4dd1dea9080e4bef4b2d4d064d847f
>
>
> Diff: https://reviews.apache.org/r/63992/diff/5/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 63992: Handled incorrect offer operation IDs in
master's ACCEPT handler.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63992/#review199303
-----------------------------------------------------------
src/master/master.cpp
Lines 4092-4098 (patched)
<https://reviews.apache.org/r/63992/#comment279599>
I wonder if doing the following would leverage the move semantics and avoid unnecessary copying:
```
*update.mutable_update_operation_status() = protobuf::createOperationStatus(...);
```
- Gaston Kleiman
On March 15, 2018, 5:02 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63992/
> -----------------------------------------------------------
>
> (Updated March 15, 2018, 5:02 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu.
>
>
> Bugs: MESOS-8190
> https://issues.apache.org/jira/browse/MESOS-8190
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds code to send operation status updates in the master's
> ACCEPT call handler. In cases where operations are dropped and in
> cases where offer operation IDs are set when they should not be, the
> master will send operation status updates for the dropped operations.
> When `SchedulerDriver` frameworks set the `id` field in an offer
> operation, the master will send them a `FrameworkErrorMessage`, as
> this feature is only supported in the HTTP scheduler API.
>
>
> Diffs
> -----
>
> src/master/master.cpp aa35abc53bfc34e19d19a93328fb6552b64c05d7
>
>
> Diff: https://reviews.apache.org/r/63992/diff/6/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 63992: Handled incorrect offer operation IDs in
master's ACCEPT handler.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63992/
-----------------------------------------------------------
(Updated March 16, 2018, 1:54 a.m.)
Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu.
Bugs: MESOS-8190
https://issues.apache.org/jira/browse/MESOS-8190
Repository: mesos
Description (updated)
-------
This patch adds code to send operation status updates in the master's
ACCEPT call handler. In cases where operations are dropped and in
cases where offer operation IDs are set when they should not be, the
master will send operation status updates for the dropped operations.
Diffs (updated)
-----
src/master/master.cpp aa35abc53bfc34e19d19a93328fb6552b64c05d7
Diff: https://reviews.apache.org/r/63992/diff/7/
Changes: https://reviews.apache.org/r/63992/diff/6-7/
Testing
-------
make check
Thanks,
Greg Mann
Re: Review Request 63992: Handled incorrect offer operation IDs in
master's ACCEPT handler.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63992/
-----------------------------------------------------------
(Updated March 16, 2018, 12:02 a.m.)
Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu.
Bugs: MESOS-8190
https://issues.apache.org/jira/browse/MESOS-8190
Repository: mesos
Description (updated)
-------
This patch adds code to send operation status updates in the master's
ACCEPT call handler. In cases where operations are dropped and in
cases where offer operation IDs are set when they should not be, the
master will send operation status updates for the dropped operations.
When `SchedulerDriver` frameworks set the `id` field in an offer
operation, the master will send them a `FrameworkErrorMessage`, as
this feature is only supported in the HTTP scheduler API.
Diffs
-----
src/master/master.cpp aa35abc53bfc34e19d19a93328fb6552b64c05d7
Diff: https://reviews.apache.org/r/63992/diff/6/
Testing
-------
make check
Thanks,
Greg Mann
Re: Review Request 63992: Handled incorrect offer operation IDs in
master's ACCEPT handler.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63992/
-----------------------------------------------------------
(Updated March 16, 2018, 12:01 a.m.)
Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu.
Bugs: MESOS-8190
https://issues.apache.org/jira/browse/MESOS-8190
Repository: mesos
Description
-------
This patch adds code to send operation status updates in the master's
ACCEPT call handler. In cases where operations are dropped and in
cases where offer operation IDs are set when they should not be, the
master will send operation status updates for the dropped operations.
Diffs (updated)
-----
src/master/master.cpp aa35abc53bfc34e19d19a93328fb6552b64c05d7
Diff: https://reviews.apache.org/r/63992/diff/6/
Changes: https://reviews.apache.org/r/63992/diff/5-6/
Testing
-------
make check
Thanks,
Greg Mann
Re: Review Request 63992: Handled incorrect offer operation IDs in
master's ACCEPT handler.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63992/
-----------------------------------------------------------
(Updated March 13, 2018, 9:49 p.m.)
Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu.
Bugs: MESOS-8190
https://issues.apache.org/jira/browse/MESOS-8190
Repository: mesos
Description
-------
This patch adds code to send operation status updates in the master's
ACCEPT call handler. In cases where operations are dropped and in
cases where offer operation IDs are set when they should not be, the
master will send operation status updates for the dropped operations.
Diffs (updated)
-----
src/master/master.cpp 223ebf29ac4dd1dea9080e4bef4b2d4d064d847f
Diff: https://reviews.apache.org/r/63992/diff/5/
Changes: https://reviews.apache.org/r/63992/diff/4-5/
Testing
-------
make check
Thanks,
Greg Mann
Re: Review Request 63992: Handled incorrect offer operation IDs in
master's ACCEPT handler.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63992/#review199121
-----------------------------------------------------------
src/master/master.cpp
Lines 4075-4082 (original), 4111-4117 (patched)
<https://reviews.apache.org/r/63992/#comment279431>
Nitpick: the comment looks a bit redundant. I'd go with this:
```
// The `id` field is set, which means operation feedback is requested.
//
// Operation feedback is not supported for LAUNCH or LAUNCH_GROUP
// operations, so we drop them and send TASK_ERROR status updates.
//
// For other operatations verify that they are destined for an agent
// with the RESOURCE_PROVIDER capability.
```
- Gaston Kleiman
On March 13, 2018, 9:38 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63992/
> -----------------------------------------------------------
>
> (Updated March 13, 2018, 9:38 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu.
>
>
> Bugs: MESOS-8190
> https://issues.apache.org/jira/browse/MESOS-8190
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds code to send operation status updates in the master's
> ACCEPT call handler. In cases where operations are dropped and in
> cases where offer operation IDs are set when they should not be, the
> master will send operation status updates for the dropped operations.
>
>
> Diffs
> -----
>
> src/master/master.cpp 223ebf29ac4dd1dea9080e4bef4b2d4d064d847f
>
>
> Diff: https://reviews.apache.org/r/63992/diff/4/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 63992: Handled incorrect offer operation IDs in
master's ACCEPT handler.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63992/
-----------------------------------------------------------
(Updated March 13, 2018, 4:38 p.m.)
Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu.
Bugs: MESOS-8190
https://issues.apache.org/jira/browse/MESOS-8190
Repository: mesos
Description
-------
This patch adds code to send operation status updates in the master's
ACCEPT call handler. In cases where operations are dropped and in
cases where offer operation IDs are set when they should not be, the
master will send operation status updates for the dropped operations.
Diffs (updated)
-----
src/master/master.cpp 223ebf29ac4dd1dea9080e4bef4b2d4d064d847f
Diff: https://reviews.apache.org/r/63992/diff/4/
Changes: https://reviews.apache.org/r/63992/diff/3-4/
Testing
-------
make check
Thanks,
Greg Mann
Re: Review Request 63992: Handled incorrect offer operation IDs in
master's ACCEPT handler.
Posted by Greg Mann <gr...@mesosphere.io>.
> On March 7, 2018, 7:21 p.m., Gaston Kleiman wrote:
> > src/master/master.cpp
> > Line 4136 (original), 4184 (patched)
> > <https://reviews.apache.org/r/63992/diff/3/?file=1969375#file1969375line4188>
> >
> > If the operation has an operation ID, we'll always land on this `continue` even if the validations/checks pass.
> >
> > This means that line #4187 will be skipped, and operations with an operatin ID won't be added to the object passed to the `_accept` continuation.
>
> Greg Mann wrote:
> Ah thank you; this should be removed.
I elected to add another case to the conditional because I thought this was more readable; let me know what you think.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63992/#review198812
-----------------------------------------------------------
On March 13, 2018, 4:38 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63992/
> -----------------------------------------------------------
>
> (Updated March 13, 2018, 4:38 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu.
>
>
> Bugs: MESOS-8190
> https://issues.apache.org/jira/browse/MESOS-8190
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds code to send operation status updates in the master's
> ACCEPT call handler. In cases where operations are dropped and in
> cases where offer operation IDs are set when they should not be, the
> master will send operation status updates for the dropped operations.
>
>
> Diffs
> -----
>
> src/master/master.cpp 223ebf29ac4dd1dea9080e4bef4b2d4d064d847f
>
>
> Diff: https://reviews.apache.org/r/63992/diff/4/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 63992: Handled incorrect offer operation IDs in
master's ACCEPT handler.
Posted by Greg Mann <gr...@mesosphere.io>.
> On March 7, 2018, 7:21 p.m., Gaston Kleiman wrote:
> > src/master/master.cpp
> > Line 4136 (original), 4184 (patched)
> > <https://reviews.apache.org/r/63992/diff/3/?file=1969375#file1969375line4188>
> >
> > If the operation has an operation ID, we'll always land on this `continue` even if the validations/checks pass.
> >
> > This means that line #4187 will be skipped, and operations with an operatin ID won't be added to the object passed to the `_accept` continuation.
Ah thank you; this should be removed.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63992/#review198812
-----------------------------------------------------------
On March 2, 2018, 10:52 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63992/
> -----------------------------------------------------------
>
> (Updated March 2, 2018, 10:52 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu.
>
>
> Bugs: MESOS-8190
> https://issues.apache.org/jira/browse/MESOS-8190
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds code to send operation status updates in the master's
> ACCEPT call handler. In cases where operations are dropped and in
> cases where offer operation IDs are set when they should not be, the
> master will send operation status updates for the dropped operations.
>
>
> Diffs
> -----
>
> src/master/master.cpp 9cea7bb6a6ee8bf5f4226d07111bcfa6f5d3a88c
>
>
> Diff: https://reviews.apache.org/r/63992/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 63992: Handled incorrect offer operation IDs in
master's ACCEPT handler.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
> On March 7, 2018, 11:21 a.m., Gaston Kleiman wrote:
> > src/master/master.cpp
> > Line 4136 (original), 4184 (patched)
> > <https://reviews.apache.org/r/63992/diff/3/?file=1969375#file1969375line4188>
> >
> > If the operation has an operation ID, we'll always land on this `continue` even if the validations/checks pass.
> >
> > This means that line #4187 will be skipped, and operations with an operatin ID won't be added to the object passed to the `_accept` continuation.
>
> Greg Mann wrote:
> Ah thank you; this should be removed.
>
> Greg Mann wrote:
> I elected to add another case to the conditional because I thought this was more readable; let me know what you think.
LGTM!
- Gaston
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63992/#review198812
-----------------------------------------------------------
On March 13, 2018, 9:38 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63992/
> -----------------------------------------------------------
>
> (Updated March 13, 2018, 9:38 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu.
>
>
> Bugs: MESOS-8190
> https://issues.apache.org/jira/browse/MESOS-8190
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds code to send operation status updates in the master's
> ACCEPT call handler. In cases where operations are dropped and in
> cases where offer operation IDs are set when they should not be, the
> master will send operation status updates for the dropped operations.
>
>
> Diffs
> -----
>
> src/master/master.cpp 223ebf29ac4dd1dea9080e4bef4b2d4d064d847f
>
>
> Diff: https://reviews.apache.org/r/63992/diff/4/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 63992: Handled incorrect offer operation IDs in
master's ACCEPT handler.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63992/#review198812
-----------------------------------------------------------
src/master/master.cpp
Line 4136 (original), 4184 (patched)
<https://reviews.apache.org/r/63992/#comment279057>
If the operation has an operation ID, we'll always land on this `continue` even if the validations/checks pass.
This means that line #4187 will be skipped, and operations with an operatin ID won't be added to the object passed to the `_accept` continuation.
- Gaston Kleiman
On March 2, 2018, 2:52 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63992/
> -----------------------------------------------------------
>
> (Updated March 2, 2018, 2:52 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu.
>
>
> Bugs: MESOS-8190
> https://issues.apache.org/jira/browse/MESOS-8190
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds code to send operation status updates in the master's
> ACCEPT call handler. In cases where operations are dropped and in
> cases where offer operation IDs are set when they should not be, the
> master will send operation status updates for the dropped operations.
>
>
> Diffs
> -----
>
> src/master/master.cpp 9cea7bb6a6ee8bf5f4226d07111bcfa6f5d3a88c
>
>
> Diff: https://reviews.apache.org/r/63992/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 63992: Handled incorrect offer operation IDs in
master's ACCEPT handler.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63992/
-----------------------------------------------------------
(Updated March 2, 2018, 10:52 p.m.)
Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu.
Changes
-------
Rebase.
Bugs: MESOS-8190
https://issues.apache.org/jira/browse/MESOS-8190
Repository: mesos
Description
-------
This patch adds code to send operation status updates in the master's
ACCEPT call handler. In cases where operations are dropped and in
cases where offer operation IDs are set when they should not be, the
master will send operation status updates for the dropped operations.
Diffs (updated)
-----
src/master/master.cpp 9cea7bb6a6ee8bf5f4226d07111bcfa6f5d3a88c
Diff: https://reviews.apache.org/r/63992/diff/3/
Changes: https://reviews.apache.org/r/63992/diff/2-3/
Testing
-------
make check
Thanks,
Greg Mann