You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/06/01 17:26:18 UTC
[GitHub] [incubator-gobblin] ZihanLi58 opened a new pull request #3007: [GOBBLIN-1165] Add config to enable user to set additional yarn classpathes
ZihanLi58 opened a new pull request #3007:
URL: https://github.com/apache/incubator-gobblin/pull/3007
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
Test in pipeline that the configure can work
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] ZihanLi58 closed pull request #3007: [GOBBLIN-1165] Add config to enable user to set additional yarn classpathes
Posted by GitBox <gi...@apache.org>.
ZihanLi58 closed pull request #3007:
URL: https://github.com/apache/incubator-gobblin/pull/3007
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #3007: [GOBBLIN-1165] Add config to enable user to set additional yarn classpathes
Posted by GitBox <gi...@apache.org>.
sv2000 commented on a change in pull request #3007:
URL: https://github.com/apache/incubator-gobblin/pull/3007#discussion_r433469870
##########
File path: gobblin-modules/gobblin-kafka-09/src/test/java/org/apache/gobblin/metrics/reporter/KafkaKeyValueProducerPusherTest.java
##########
@@ -42,6 +42,7 @@
/**
* Test {@link KafkaKeyValueProducerPusher}.
*/
+@Test (groups = {"disabledOnTravis"})
Review comment:
Let's remove this, since this test is not the root cause of travis build failures.
##########
File path: gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnHelixUtils.java
##########
@@ -46,8 +47,9 @@
*
* @author Yinan Li
*/
+@Slf4j
public class YarnHelixUtils {
-
+ public static final String ADDITIONAL_YARN_CLASSPATH = "additional.yarn.classpath";
Review comment:
Should this config be part of GobblinYarnConfigurationKeys? e.g. gobblin.yarn.additional.classpaths?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] ZihanLi58 closed pull request #3007: [GOBBLIN-1165] Add config to enable user to set additional yarn classpathes
Posted by GitBox <gi...@apache.org>.
ZihanLi58 closed pull request #3007:
URL: https://github.com/apache/incubator-gobblin/pull/3007
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] ZihanLi58 closed pull request #3007: [GOBBLIN-1165] Add config to enable user to set additional yarn classpathes
Posted by GitBox <gi...@apache.org>.
ZihanLi58 closed pull request #3007:
URL: https://github.com/apache/incubator-gobblin/pull/3007
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org