[GitHub] [ignite-3] ascherbakoff commented on a change in pull request #321: IGNITE-15288 Fully implement RaftGroupService

[GitBox <gi...@apache.org>]

ascherbakoff commented on a change in pull request #321:
URL: https://github.com/apache/ignite-3/pull/321#discussion_r709871221



##########
File path: modules/raft/src/main/java/org/apache/ignite/raft/jraft/rpc/impl/RaftGroupServiceImpl.java
##########
@@ -71,16 +79,16 @@
     private final String groupId;
 
     /** */
-    private final RaftClientMessagesFactory factory;
+    private final RaftMessagesFactory factory;
 
     /** */
-    private volatile Peer leader;
+    private volatile PeerId leader;
 
     /** */
-    private volatile List<Peer> peers;
+    private volatile List<PeerId> peers;
 
     /** */
-    private volatile List<Peer> learners;
+    private volatile List<PeerId> learners;

Review comment:
       It would be better to store Peer in the fields instead of PeerId to avoid multiple conversions on calling getters.
   The conversion should be done only on request/response sending/receiving.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org