FS API functions missing FS API tests

[Stefan Fuhrmann <st...@wandisco.com>]

Hi there,

I've been going through svn_fs.h and found that the following
functions aren't being called directly in any of our tests. They
may still be tested indirectly through higher level functions but
I think most of them should get a low-level test as well:

svn_fs_access_get_username
svn_fs_access_add_lock_token2
svn_fs_purge_txn
svn_fs_txn_base_revision
svn_fs_is_txn_root
svn_fs_is_revision_root
svn_fs_txn_root_name
svn_fs_path_change2_create
svn_fs_check_path
svn_fs_is_file
svn_fs_node_relation
svn_fs_node_created_path
svn_fs_props_different
svn_fs_props_changed
svn_fs_get_mergeinfo2
svn_fs_merge
svn_fs_dir_optimal_order
svn_fs_file_length
svn_fs_file_checksum(sha1)
svn_fs_try_process_file_contents
svn_fs_contents_different
svn_fs_contents_changed
svn_fs_info_config_files
svn_fs_get_file_delta_stream
svn_fs_lock_target_set_token
svn_fs_get_locks2
svn_fs_print_modules

[svn_fs_node_history2, svn_fs_history_prev2 are opaque and will
 be tested through 'svn log']

I'll be working through that list by the end of this week and add
tests where they are simple enough and then post an updated list
here.

-- Stefan^2.

Re: FS API functions missing FS API tests

[Stefan Fuhrmann <st...@wandisco.com>]

On Mon, Oct 20, 2014 at 3:16 PM, Stefan Fuhrmann <
stefan.fuhrmann@wandisco.com> wrote:

Functions yet to cover by test_fs:

svn_fs_path_change2_create
svn_fs_node_created_path

svn_fs_dir_optimal_order
svn_fs_try_process_file_contents
svn_fs_get_file_delta_stream
svn_fs_get_mergeinfo2
svn_fs_info_config_files
svn_fs_print_modules

svn_fs_merge

svn_fs_access_get_username
svn_fs_access_add_lock_token2
svn_fs_lock_target_set_token
svn_fs_get_locks2

The first group is trivial, the second straight-forward.
svn_fs_merge is not used within SVN and may require
substantial effort to get tested. The last group is
concerned with locking functionality that I have not
looked into, yet.

None of these are blockers for 1.9.

-- Stefan^2.