You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "ok2c (via GitHub)" <gi...@apache.org> on 2023/03/15 18:25:32 UTC

[GitHub] [httpcomponents-client] ok2c commented on pull request #424: Fix issue with duplicate parsing of Cache-Control header

ok2c commented on PR #424:
URL: https://github.com/apache/httpcomponents-client/pull/424#issuecomment-1470546470

   Committed as 8ba0b17aebdcc59a43a3785d751e63cddc2c8a58 with some changes to the parsing code.
   
   @arturobernalg The trick was to reverse the parsing flow and make it simple and linear. Fewer lines of code, fewer intermediate garbage as a result. 
   I committed by code under your name as going back and forth with each and every line of change would have taken too long. Please take a look at my changes.
   
   And why on earth did you choose to use deprecated `DateUtils` methods in your tests?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org