You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2016/05/10 05:34:52 UTC

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-843] Comment showing up...

GitHub user prabhjyotsingh opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/879

    [ZEPPELIN-843] Comment showing up on issues.apache.org is wrong

    ### What is this PR for?
    When using merge_zeppelin_pr.py utility the comment that shows up on issues.apache.org is wrong. The URL that prints is "pulls", it should be "pull"
    It shows up as :
    
        Issue resolved by pull request 874
        https://github.com/apache/incubator-zeppelin/pulls/874
    
    
    It should be :
        
        Issue resolved by pull request 874
        https://github.com/apache/incubator-zeppelin/pull/874
    
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    N/A
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-843
    
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prabhjyotsingh/incubator-zeppelin ZEPPELIN-843

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/879.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #879
    
----
commit 189f4684228e1d6228c0980bd8000524e2fe2601
Author: Prabhjyot Singh <pr...@gmail.com>
Date:   2016-05-10T05:32:02Z

    fix : Comment showing up on issues.apache.org is wrong

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-843] Comment showing up...

Posted by prabhjyotsingh <gi...@git.apache.org>.

Github user prabhjyotsingh commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/879#issuecomment-218655449
  
    Merging this, if no more discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-843] Comment showing up...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/879


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-843] Comment showing up...

Posted by khalidhuseynov <gi...@git.apache.org>.

Github user khalidhuseynov commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/879#issuecomment-218380375
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---