You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "xtern (via GitHub)" <gi...@apache.org> on 2025/08/15 13:54:45 UTC
[PR] Sql. Fixed flaky test ItSqlMultiStatementTest.statementRestrictedByQueryType. [ignite-3]
xtern opened a new pull request, #6434:
URL: https://github.com/apache/ignite-3/pull/6434
https://issues.apache.org/jira/browse/IGNITE-26218
Test fails because `fetchCursors` does not wait for all cursors to close.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-26218 Sql. Fixed flaky test ItSqlMultiStatementTest.statementRestrictedByQueryType. [ignite-3]
Posted by "ygerzhedovich (via GitHub)" <gi...@apache.org>.
ygerzhedovich commented on code in PR #6434:
URL: https://github.com/apache/ignite-3/pull/6434#discussion_r2287161596
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/BaseSqlMultiStatementTest.java:
##########
@@ -123,13 +118,17 @@ protected List<AsyncSqlCursor<InternalSqlRow>> fetchCursors(AsyncSqlCursor<Inter
cursors.add(cursor);
- if (close) {
- cursor.closeAsync();
- } else {
+ if (!close) {
cursorsToClose.add(cursor);
}
}
Review Comment:
Let's check here that we iterate all cursors, like a
`` assertFalse(cursor.hasNextResult()); ``
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-26218 Sql. Fixed flaky test ItSqlMultiStatementTest.statementRestrictedByQueryType. [ignite-3]
Posted by "xtern (via GitHub)" <gi...@apache.org>.
xtern commented on code in PR #6434:
URL: https://github.com/apache/ignite-3/pull/6434#discussion_r2287218869
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/BaseSqlMultiStatementTest.java:
##########
@@ -123,13 +118,17 @@ protected List<AsyncSqlCursor<InternalSqlRow>> fetchCursors(AsyncSqlCursor<Inter
cursors.add(cursor);
- if (close) {
- cursor.closeAsync();
- } else {
+ if (!close) {
cursorsToClose.add(cursor);
}
}
Review Comment:
The loop already has this condition.
We can iterate not all cursors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-26218 Sql. Fixed flaky test ItSqlMultiStatementTest.statementRestrictedByQueryType. [ignite-3]
Posted by "xtern (via GitHub)" <gi...@apache.org>.
xtern merged PR #6434:
URL: https://github.com/apache/ignite-3/pull/6434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org