You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/18 03:08:09 UTC

[GitHub] [pulsar] thomasleplus opened a new pull request #12082: Fix last exit code storage

thomasleplus opened a new pull request #12082:
URL: https://github.com/apache/pulsar/pull/12082


   This line was actually assigning the method argument to itself instead of setting the static field of the same name.
   
   
   ### Motivation
   
   Fix a simple mistake.
   
   ### Modifications
   
   Trivial change.
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API: no
     - The schema: no
     - The default values of configurations: no
     - The wire protocol: no
     - The rest endpoints: no
     - The admin cli options: no
     - Anything that affects deployment: no
   
   ### Documentation
   
   Check the box below and label this PR (if you have committer privilege).
   
   Need to update docs? 
   
   - [ ] doc-required 
   - [x] no-need-doc 
   - [ ] doc 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #12082: Fix last exit code storage

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #12082:
URL: https://github.com/apache/pulsar/pull/12082#issuecomment-922337021


   It is a flaky test. Don't bother
   
   
   Thank you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] 315157973 commented on pull request #12082: PulsarAdmin: Fix last exit code storage

Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #12082:
URL: https://github.com/apache/pulsar/pull/12082#issuecomment-957075256


   > > @thomasleplus Sorry， I closed this PR by mistake, could you please open  it again?
   > 
   > GitHub doesn't let me because I've deleted my fork repo. My bad. Maybe their support team can reopen the request, they are pretty good and reactive in my experience. Otherwise I can create another PR. Let me know what you think is best.
   
   Let's create a new PR, I want to merge it as soon as possible, 2.8.2 is releasing


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] thomasleplus commented on pull request #12082: PulsarAdmin: Fix last exit code storage

Posted by GitBox <gi...@apache.org>.
thomasleplus commented on pull request #12082:
URL: https://github.com/apache/pulsar/pull/12082#issuecomment-957072441






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] thomasleplus commented on pull request #12082: PulsarAdmin: Fix last exit code storage

Posted by GitBox <gi...@apache.org>.
thomasleplus commented on pull request #12082:
URL: https://github.com/apache/pulsar/pull/12082#issuecomment-957072441






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] 315157973 closed pull request #12082: PulsarAdmin: Fix last exit code storage

Posted by GitBox <gi...@apache.org>.
315157973 closed pull request #12082:
URL: https://github.com/apache/pulsar/pull/12082


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] thomasleplus commented on pull request #12082: PulsarAdmin: Fix last exit code storage

Posted by GitBox <gi...@apache.org>.
thomasleplus commented on pull request #12082:
URL: https://github.com/apache/pulsar/pull/12082#issuecomment-923087207


   Hi @codelipenghui, I see that you assigned this PR back to me, does this mean there is something left for me to do?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] thomasleplus commented on pull request #12082: PulsarAdmin: Fix last exit code storage

Posted by GitBox <gi...@apache.org>.
thomasleplus commented on pull request #12082:
URL: https://github.com/apache/pulsar/pull/12082#issuecomment-957079068


   Sure, here you go: #12581


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] 315157973 closed pull request #12082: PulsarAdmin: Fix last exit code storage

Posted by GitBox <gi...@apache.org>.
315157973 closed pull request #12082:
URL: https://github.com/apache/pulsar/pull/12082


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] 315157973 commented on pull request #12082: PulsarAdmin: Fix last exit code storage

Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #12082:
URL: https://github.com/apache/pulsar/pull/12082#issuecomment-957051186


   @thomasleplus Sorry， I closed this PR by mistake, could you please open  it again?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] 315157973 closed pull request #12082: PulsarAdmin: Fix last exit code storage

Posted by GitBox <gi...@apache.org>.
315157973 closed pull request #12082:
URL: https://github.com/apache/pulsar/pull/12082


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #12082: PulsarAdmin: Fix last exit code storage

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #12082:
URL: https://github.com/apache/pulsar/pull/12082#issuecomment-923820579


   it means that you are the author of the PR, nothing more.
   this way it is easier to "count" your contributions, and finally someday invite you as a committer :-) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] 315157973 commented on pull request #12082: PulsarAdmin: Fix last exit code storage

Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #12082:
URL: https://github.com/apache/pulsar/pull/12082#issuecomment-956031144


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] thomasleplus commented on pull request #12082: PulsarAdmin: Fix last exit code storage

Posted by GitBox <gi...@apache.org>.
thomasleplus commented on pull request #12082:
URL: https://github.com/apache/pulsar/pull/12082#issuecomment-957072441


   > @thomasleplus Sorry， I closed this PR by mistake, could you please open  it again?
   
   GitHub doesn't let me because I've deleted my fork repo. My bad. Maybe their support team can reopen the request, they are pretty good and reactive in my experience. Otherwise I can create another PR. Let me know what you think is best. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] 315157973 commented on pull request #12082: PulsarAdmin: Fix last exit code storage

Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #12082:
URL: https://github.com/apache/pulsar/pull/12082#issuecomment-957051186






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] thomasleplus commented on pull request #12082: Fix last exit code storage

Posted by GitBox <gi...@apache.org>.
thomasleplus commented on pull request #12082:
URL: https://github.com/apache/pulsar/pull/12082#issuecomment-922334170


   I am investigating the failing test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli edited a comment on pull request #12082: Fix last exit code storage

Posted by GitBox <gi...@apache.org>.
eolivelli edited a comment on pull request #12082:
URL: https://github.com/apache/pulsar/pull/12082#issuecomment-922337021


   It is probably a flaky test. Don't bother
   
   
   Thank you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] 315157973 commented on pull request #12082: PulsarAdmin: Fix last exit code storage

Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #12082:
URL: https://github.com/apache/pulsar/pull/12082#issuecomment-957051186






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org