[GitHub] mistercrunch opened a new pull request #4771: [druid] fix 'Unorderable types' when col has nuls

[GitBox <gi...@apache.org>]

mistercrunch opened a new pull request #4771: [druid] fix 'Unorderable types' when col has nuls
URL: https://github.com/apache/incubator-superset/pull/4771
 
 
   Error "unorderable types: str() < int()" occurs when grouping by a
   numerical Druid colummn that contains null values.
   
   * druid/pydruid returns strings in the datafram with NAs for nulls
   * Superset has custom logic around get_fillna_for_col that fills in the
   NULLs based on declared column type (FLOAT here), so now we have a mixed
   bag of type in the series
   * pandas chokes on pivot_table or groupby operations as it cannot sorts
   mixed types
   
   The approach here is to stringify and fillna('<NULL>') to get a
   consistent series.
   
   Related: https://github.com/apache/incubator-superset/issues/3029

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services