You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2020/11/26 00:58:01 UTC
[GitHub] [incubator-daffodil-site] mbeckerle opened a new pull request #30: Update DFDL Specification to link to r35 public review HTML version
mbeckerle opened a new pull request #30:
URL: https://github.com/apache/incubator-daffodil-site/pull/30
DAFFODIL-2442
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-daffodil-site] mbeckerle commented on pull request #30: Update DFDL Specification to link to r35 public review HTML version
Posted by GitBox <gi...@apache.org>.
mbeckerle commented on pull request #30:
URL: https://github.com/apache/incubator-daffodil-site/pull/30#issuecomment-735911907
https://github.com/OpenGridForum/Editor/issues/12 is the public comment about this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-daffodil-site] mbeckerle commented on pull request #30: Update DFDL Specification to link to r35 public review HTML version
Posted by GitBox <gi...@apache.org>.
mbeckerle commented on pull request #30:
URL: https://github.com/apache/incubator-daffodil-site/pull/30#issuecomment-735910387
It is an objective for this HTML to be "fully elastic" to any width. Setting widths has caused many problems with tables, etc. So removing all the style information so that everything presents at the full-width of the browser window used has actually been a goal.
That said, I've been adding formatting related issues as public-review comments to the public review.
The work around, which is to narrow the browser window being used, is easy enough.
This HTML version is also the public-review draft and will be replaced later with the official version once that is out, probably early in 2021. At that point we can deal with formatting considerations. There are numerous others besides this one. MS-Word is pretty bad at preserving style uniformity when creating HTML.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-daffodil-site] mbeckerle merged pull request #30: Update DFDL Specification to link to r35 public review HTML version
Posted by GitBox <gi...@apache.org>.
mbeckerle merged pull request #30:
URL: https://github.com/apache/incubator-daffodil-site/pull/30
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-daffodil-site] stevedlawrence commented on pull request #30: Update DFDL Specification to link to r35 public review HTML version
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on pull request #30:
URL: https://github.com/apache/incubator-daffodil-site/pull/30#issuecomment-735870610
+1 with one minor comment:
I can't make an inline comment since github won't show the large diff, but part of this change removes the following in index.html:
```diff
-body {
- max-width: 1024px;
- margin: auto;
-}
```
I suspect this bit of CSS isn't part of the autogenerated HTML and that someone (probably me?) added it later, but I think this would be a change worth keeping. This makes it so the DFDL docs don't grow beyond a width of 1024 pixels, which can be helpful on widescreens. Ottherwise it's a bit hard to read with super long lines.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org