You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "bschuchardt (GitHub)" <gi...@apache.org> on 2018/11/10 00:10:56 UTC
[GitHub] [geode] bschuchardt opened pull request #2835: GEODE-5072
Java clients should not access or modify internal regions
_This PR is not ready for review until CI tasks pass_
Modified the kind of cache available to client/server command processing
in order to restrict access to internal regions.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/2835 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] bschuchardt closed pull request #2835: GEODE-5072
Java clients should not access or modify internal regions
Posted by "bschuchardt (GitHub)" <gi...@apache.org>.
[ pull request closed by bschuchardt ]
[ Full content available at: https://github.com/apache/geode/pull/2835 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] kirklund commented on pull request #2835: GEODE-5072
Java clients should not access or modify internal regions
Posted by "kirklund (GitHub)" <gi...@apache.org>.
If you're not using DistributedRule, then you should also add this to the end of your tearDown method or this dunit won't do any grepping for suspect strings:
```
DUnitLauncher.closeAndCheckForSuspects();
```
[ Full content available at: https://github.com/apache/geode/pull/2835 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] bschuchardt commented on issue #2835: GEODE-5072
Java clients should not access or modify internal regions
Posted by "bschuchardt (GitHub)" <gi...@apache.org>.
Thanks Kirk - I've already changed the test to use DistributedRule but didn't think another push was warranted
[ Full content available at: https://github.com/apache/geode/pull/2835 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org