You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by keval bhatt <ke...@freestoneinfotech.com> on 2016/05/12 07:38:09 UTC
Review Request 47293: ATLAS-736 :: UI - BUG :: displaying timestamp
values for hive_db description
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47293/
-----------------------------------------------------------
Review request for atlas, Ayub Pathan, Gautam Borad, Shwetha GS, Selvamohan Neethiraj, and Hemanth Yamijala.
Bugs: ATLAS-736
https://issues.apache.org/jira/browse/ATLAS-736
Repository: atlas
Description
-------
Bug Description : Showing date in description if description is null same for other colums
Changed: * Validation added to handle null value and showing empty value.
* Removed Tools column for add tag and add tag button displayed after tags.
* Search table loading effect improvements.
* Header Menu fix.
Diffs
-----
dashboardv2/public/css/override.css 4c452cc
dashboardv2/public/index.html c2f15c9
dashboardv2/public/js/views/asset/AssetPageLayoutView.js c86fef4
dashboardv2/public/js/views/schema/SchemaLayoutView.js 35487a5
dashboardv2/public/js/views/site/Header.js 500bd91
dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js c5e1ace
Diff: https://reviews.apache.org/r/47293/diff/
Testing
-------
Manually tested the changes.
Thanks,
keval bhatt
Re: Review Request 47293: ATLAS-736 :: UI - BUG :: displaying
timestamp values for hive_db description
Posted by Hemanth Yamijala <yh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47293/#review133531
-----------------------------------------------------------
Ship it!
Ship It!
- Hemanth Yamijala
On May 13, 2016, 10:39 a.m., keval bhatt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47293/
> -----------------------------------------------------------
>
> (Updated May 13, 2016, 10:39 a.m.)
>
>
> Review request for atlas, Ayub Pathan, Gautam Borad, Shwetha GS, Selvamohan Neethiraj, and Hemanth Yamijala.
>
>
> Bugs: ATLAS-736
> https://issues.apache.org/jira/browse/ATLAS-736
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Bug Description : Showing date in description if description is null same for other colums
>
> Changed: * Validation added to handle null value and showing empty value.
> * Removed Tools column for add tag and add tag button displayed after tags.
> * Search table loading effect improvements.
> * Header Menu fix.
>
>
> Diffs
> -----
>
> dashboardv2/public/css/override.css 4c452cc
> dashboardv2/public/index.html c2f15c9
> dashboardv2/public/js/utils/CommonViewFunction.js PRE-CREATION
> dashboardv2/public/js/views/asset/AssetPageLayoutView.js c86fef4
> dashboardv2/public/js/views/schema/SchemaLayoutView.js 35487a5
> dashboardv2/public/js/views/site/Header.js 500bd91
> dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js c5e1ace
> dashboardv2/public/js/views/tag/addTagModalView.js d663ae2
>
> Diff: https://reviews.apache.org/r/47293/diff/
>
>
> Testing
> -------
>
> Manually tested the changes.
>
>
> Thanks,
>
> keval bhatt
>
>
Re: Review Request 47293: ATLAS-736 :: UI - BUG :: displaying
timestamp values for hive_db description
Posted by keval bhatt <ke...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47293/
-----------------------------------------------------------
(Updated May 13, 2016, 10:39 a.m.)
Review request for atlas, Ayub Pathan, Gautam Borad, Shwetha GS, Selvamohan Neethiraj, and Hemanth Yamijala.
Changes
-------
Handled all your suggestions.
Overall Patch contains ::
1) It takes care of Null values in all Table columns (in search result Table).
2) Corrected error response as well as success message as per your suggestion.
3) Corrected display of Top Navigation menu item of current page (sometimes it was showing improper top navigation menu item)
4) Improvised by adding a common function view to show the modal for Delete Tag.
Bugs: ATLAS-736
https://issues.apache.org/jira/browse/ATLAS-736
Repository: atlas
Description
-------
Bug Description : Showing date in description if description is null same for other colums
Changed: * Validation added to handle null value and showing empty value.
* Removed Tools column for add tag and add tag button displayed after tags.
* Search table loading effect improvements.
* Header Menu fix.
Diffs (updated)
-----
dashboardv2/public/css/override.css 4c452cc
dashboardv2/public/index.html c2f15c9
dashboardv2/public/js/utils/CommonViewFunction.js PRE-CREATION
dashboardv2/public/js/views/asset/AssetPageLayoutView.js c86fef4
dashboardv2/public/js/views/schema/SchemaLayoutView.js 35487a5
dashboardv2/public/js/views/site/Header.js 500bd91
dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js c5e1ace
dashboardv2/public/js/views/tag/addTagModalView.js d663ae2
Diff: https://reviews.apache.org/r/47293/diff/
Testing
-------
Manually tested the changes.
Thanks,
keval bhatt
Re: Review Request 47293: ATLAS-736 :: UI - BUG :: displaying
timestamp values for hive_db description
Posted by Hemanth Yamijala <yh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47293/#review133044
-----------------------------------------------------------
dashboardv2/public/js/views/asset/AssetPageLayoutView.js (line 385)
<https://reviews.apache.org/r/47293/#comment197346>
I can see this message when I delete a tag from the results table. But can't see it if the same is deleted from the Tags table in the asset page. You can take this as part of another JIRA if you want.
dashboardv2/public/js/views/asset/AssetPageLayoutView.js (line 396)
<https://reviews.apache.org/r/47293/#comment197342>
Could we have a better message here? Something like "Tag <name> could not be deleted".
dashboardv2/public/js/views/schema/SchemaLayoutView.js (line 200)
<https://reviews.apache.org/r/47293/#comment197343>
Looks like this code is duplicate in AssetPageLayoutView as well. Can this be refactored into being at one place?
- Hemanth Yamijala
On May 12, 2016, 7:38 a.m., keval bhatt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47293/
> -----------------------------------------------------------
>
> (Updated May 12, 2016, 7:38 a.m.)
>
>
> Review request for atlas, Ayub Pathan, Gautam Borad, Shwetha GS, Selvamohan Neethiraj, and Hemanth Yamijala.
>
>
> Bugs: ATLAS-736
> https://issues.apache.org/jira/browse/ATLAS-736
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Bug Description : Showing date in description if description is null same for other colums
>
> Changed: * Validation added to handle null value and showing empty value.
> * Removed Tools column for add tag and add tag button displayed after tags.
> * Search table loading effect improvements.
> * Header Menu fix.
>
>
> Diffs
> -----
>
> dashboardv2/public/css/override.css 4c452cc
> dashboardv2/public/index.html c2f15c9
> dashboardv2/public/js/views/asset/AssetPageLayoutView.js c86fef4
> dashboardv2/public/js/views/schema/SchemaLayoutView.js 35487a5
> dashboardv2/public/js/views/site/Header.js 500bd91
> dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js c5e1ace
>
> Diff: https://reviews.apache.org/r/47293/diff/
>
>
> Testing
> -------
>
> Manually tested the changes.
>
>
> Thanks,
>
> keval bhatt
>
>