You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "huangzhir (via GitHub)" <gi...@apache.org> on 2023/04/14 23:51:46 UTC
[GitHub] [kyuubi] huangzhir opened a new pull request, #4714: KYUUBI #4713] fix TEST SchedulerPoolSuite a false positive result
huangzhir opened a new pull request, #4714:
URL: https://github.com/apache/kyuubi/pull/4714
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
1. fix issuse https://github.com/apache/kyuubi/issues/4713
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ XX] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] codecov-commenter commented on pull request #4714: KYUUBI #4713] fix TEST SchedulerPoolSuite a false positive result
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4714:
URL: https://github.com/apache/kyuubi/pull/4714#issuecomment-1509441000
## [Codecov](https://codecov.io/gh/apache/kyuubi/pull/4714?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4714](https://codecov.io/gh/apache/kyuubi/pull/4714?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e66ede2) into [master](https://codecov.io/gh/apache/kyuubi/commit/a834ed3efb19c94035b38e7f03a442d3ce9b5423?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a834ed3) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #4714 +/- ##
============================================
+ Coverage 57.98% 58.01% +0.03%
Complexity 13 13
============================================
Files 580 580
Lines 32213 32232 +19
Branches 4304 4302 -2
============================================
+ Hits 18678 18699 +21
+ Misses 11741 11736 -5
- Partials 1794 1797 +3
```
[see 24 files with indirect coverage changes](https://codecov.io/gh/apache/kyuubi/pull/4714/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] huangzhir commented on pull request #4714: [KYUUBI #4713][TEST] Fix false positive result in SchedulerPoolSuite
Posted by "huangzhir (via GitHub)" <gi...@apache.org>.
huangzhir commented on PR #4714:
URL: https://github.com/apache/kyuubi/pull/4714#issuecomment-1512600326
@pan3793 @ulysses-you I've made some changes to the code,make sure job1 started before job2 and would appreciate it if you could review them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] huangzhir commented on pull request #4714: KYUUBI #4713] fix TEST SchedulerPoolSuite a false positive result
Posted by "huangzhir (via GitHub)" <gi...@apache.org>.
huangzhir commented on PR #4714:
URL: https://github.com/apache/kyuubi/pull/4714#issuecomment-1509435982
Cause of this issue:
1. threads.shutdown() is asynchronous.
2. When using eventually to judge, if job2 finishes first and job1 has not finished, the value of job1FinishTime is 0. job2FinishTime - job1FinishTime >= 1000 is definitely greater than 0. The main program will exit the eventually method and end the main thread.
3. However, job1 has not produced a result yet, and closing the statement and session will cause an exception.
4. The root cause is that job1 and job2 are executed in multiple threads almost simultaneously, and which one is job1 or job2 is not fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #4714: [KYUUBI #4713][TEST] Fix false positive result in SchedulerPoolSuite
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #4714:
URL: https://github.com/apache/kyuubi/pull/4714#issuecomment-1516047555
Thanks, merged to master/1.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] huangzhir commented on pull request #4714: [KYUUBI #4713][TEST] Fix false positive result in SchedulerPoolSuite
Posted by "huangzhir (via GitHub)" <gi...@apache.org>.
huangzhir commented on PR #4714:
URL: https://github.com/apache/kyuubi/pull/4714#issuecomment-1510886001
hello, @pan3793 There is an error in the code. Can you reopen this PR? This error leads to an obvious failure when checking in the 1.7 branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] huangtruman commented on a diff in pull request #4714: [KYUUBI #4713][TEST] Fix false positive result in SchedulerPoolSuite
Posted by "huangtruman (via GitHub)" <gi...@apache.org>.
huangtruman commented on code in PR #4714:
URL: https://github.com/apache/kyuubi/pull/4714#discussion_r1168318921
##########
externals/kyuubi-spark-sql-engine/src/test/scala/org/apache/kyuubi/engine/spark/SchedulerPoolSuite.scala:
##########
@@ -92,17 +95,18 @@ class SchedulerPoolSuite extends WithSparkSQLEngine with HiveJDBCTestHelper {
statement.execute("SELECT java_method('java.lang.Thread', 'sleep', 1500l)" +
" FROM range(1, 3, 1, 2)")
}
+ // make sure this job name job1
+ Thread.sleep(1000)
Review Comment:
There is an error here. Thread.sleep(1000) running in a thread does not work and cannot guarantee that the job named job1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 closed pull request #4714: [KYUUBI #4713][TEST] Fix false positive result in SchedulerPoolSuite
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #4714: [KYUUBI #4713][TEST] Fix false positive result in SchedulerPoolSuite
URL: https://github.com/apache/kyuubi/pull/4714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #4714: [KYUUBI #4713][TEST] Fix false positive result in SchedulerPoolSuite
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #4714:
URL: https://github.com/apache/kyuubi/pull/4714#issuecomment-1510575660
Thanks, merged to master/1.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 merged pull request #4714: [KYUUBI #4713][TEST] Fix false positive result in SchedulerPoolSuite
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 merged PR #4714:
URL: https://github.com/apache/kyuubi/pull/4714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org