[jira] [Commented] (FLINK-10033) Let Task release reference to Invokable on shutdown

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16567385#comment-16567385 ] 

ASF GitHub Bot commented on FLINK-10033:
----------------------------------------

StephanEwen opened a new pull request #6480: [FLINK-10033] [runtime] Task releases reference to AbstractInvokable
URL: https://github.com/apache/flink/pull/6480
 
 
   ## What is the purpose of the change
   
   References to Task objects may under some conditions linger longer than for the lifetime of the task. For example, in case of local network channels, the receiving task may have a reference to the object of the task that produced the data.
   
   To guard against memory leaks, the Task releases the reference to its AbstractInvokable
   when it shuts down or cancels.
   
   ## Brief change log
   
     - The `Task` nulls out its heap reference to the `AbstractInvokable`
     - `TaskTest` verifies that for finite task execution and cancellation
   
   ## Verifying this change
   
   Self-contained in a unit test.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive): **no**
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **no**
     - If yes, how is the feature documented? **not applicable**
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Let Task release reference to Invokable on shutdown
> ---------------------------------------------------
>
>                 Key: FLINK-10033
>                 URL: https://issues.apache.org/jira/browse/FLINK-10033
>             Project: Flink
>          Issue Type: Bug
>          Components: TaskManager
>    Affects Versions: 1.5.2
>            Reporter: Stephan Ewen
>            Assignee: Stephan Ewen
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.5.3, 1.6.0
>
>
> References to Task objects may under some conditions linger longer than for the lifetime of the task. For example, in case of local network channels, the receiving task may have a reference to the object of the task that produced the data.
> To prevent against memory leaks, the Task needs to release all references to its AbstractInvokable when it shuts down or cancels.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)