You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/05/24 14:11:30 UTC
[GitHub] [superset] diegomedina248 opened a new pull request, #20173: fix: avoid while cycle in computeMaxFontSize for big Number run forever when css rule applied
diegomedina248 opened a new pull request, #20173:
URL: https://github.com/apache/superset/pull/20173
### SUMMARY
Adding custom CSS to a dashboard with a bigInt chart would activate a while loop that didn't ever finished, which somehow wasn't caught by the surrounding ErrorBoundary cause the whole app crashed before running out of memory (my guess)
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Uploading 168395532-ef3dc781-3415-4a76-82fa-23d796395bde.mov…
### TESTING INSTRUCTIONS
1. Create a Dashboard.
2. Access it on edit mode.
3. Click on the three ellipses on the top right corner > Edit CSS.
4. Add below CSS code to it:
```css
.header-line {
font-size: 170px!important;
}
```
5. Add a Big Number Chart to the Dashboard.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #20173: fix: avoid while cycle in computeMaxFontSize for big Number run forever when css rule applied
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #20173:
URL: https://github.com/apache/superset/pull/20173#issuecomment-1136050885
# [Codecov](https://codecov.io/gh/apache/superset/pull/20173?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20173](https://codecov.io/gh/apache/superset/pull/20173?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (01df4ec) into [master](https://codecov.io/gh/apache/superset/commit/ce01ce9e2f6859b3435e6ffb5425d1c29144442c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ce01ce9) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 01df4ec differs from pull request most recent head d792183. Consider uploading reports for the commit d792183 to get more accurate results
```diff
@@ Coverage Diff @@
## master #20173 +/- ##
=======================================
Coverage 66.44% 66.44%
=======================================
Files 1721 1721
Lines 64548 64551 +3
Branches 6811 6812 +1
=======================================
+ Hits 42890 42893 +3
Misses 19925 19925
Partials 1733 1733
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.32% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/20173?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...perset-ui-core/src/dimension/computeMaxFontSize.ts](https://codecov.io/gh/apache/superset/pull/20173/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvZGltZW5zaW9uL2NvbXB1dGVNYXhGb250U2l6ZS50cw==) | `100.00% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/20173?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/20173?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ce01ce9...d792183](https://codecov.io/gh/apache/superset/pull/20173?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] diegomedina248 closed pull request #20173: fix: avoid while cycle in computeMaxFontSize for big Number run forever when css rule applied
Posted by GitBox <gi...@apache.org>.
diegomedina248 closed pull request #20173: fix: avoid while cycle in computeMaxFontSize for big Number run forever when css rule applied
URL: https://github.com/apache/superset/pull/20173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] diegomedina248 closed pull request #20173: fix: avoid while cycle in computeMaxFontSize for big Number run forever when css rule applied
Posted by GitBox <gi...@apache.org>.
diegomedina248 closed pull request #20173: fix: avoid while cycle in computeMaxFontSize for big Number run forever when css rule applied
URL: https://github.com/apache/superset/pull/20173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] diegomedina248 closed pull request #20173: fix: avoid while cycle in computeMaxFontSize for big Number run forever when css rule applied
Posted by GitBox <gi...@apache.org>.
diegomedina248 closed pull request #20173: fix: avoid while cycle in computeMaxFontSize for big Number run forever when css rule applied
URL: https://github.com/apache/superset/pull/20173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ merged pull request #20173: fix: avoid while cycle in computeMaxFontSize for big Number run forever when css rule applied
Posted by GitBox <gi...@apache.org>.
stephenLYZ merged PR #20173:
URL: https://github.com/apache/superset/pull/20173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org