You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "peter-toth (via GitHub)" <gi...@apache.org> on 2023/09/10 09:08:48 UTC
[GitHub] [spark] peter-toth opened a new pull request, #42863: [SPARK-45109][SQL][CONNECT] Fix eas_decrypt and ln functions in Connect
peter-toth opened a new pull request, #42863:
URL: https://github.com/apache/spark/pull/42863
### What changes were proposed in this pull request?
Fix `eas_descrypt` and `ln` implementations in Spark Connect. The previous `eas_descrypt` reference to `aes_encrypt` is clearly a bug. The `ln` reference to `log` is more like a cosmetic issue, but because `ln` and `log` function implementations are different in Spark SQL we should use the same implementation in Spark Connect too.
### Why are the changes needed?
Bugfix.
### Does this PR introduce _any_ user-facing change?
No, these Spark Connect functions haven't been released.
### How was this patch tested?
Esiting UTs.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] peter-toth commented on pull request #42863: [SPARK-45109][SQL][CONNECT] Fix aes_decrypt and ln functions in Connect
Posted by "peter-toth (via GitHub)" <gi...@apache.org>.
peter-toth commented on PR #42863:
URL: https://github.com/apache/spark/pull/42863#issuecomment-1713272847
Thanks all for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] peter-toth commented on pull request #42863: [SPARK-45109][SQL][CONNECT] Fix aes_decrypt and ln functions in Connect
Posted by "peter-toth (via GitHub)" <gi...@apache.org>.
peter-toth commented on PR #42863:
URL: https://github.com/apache/spark/pull/42863#issuecomment-1712807600
> @peter-toth Good catch! But the title and description of this PR may need to be corrected: eas_decrypt -> aes_decrypt 😄
Ahh, thanks, I can't belive how many times I've made that typo...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #42863: [SPARK-45109][SQL][CONNECT] Fix aes_decrypt and ln functions in Connect
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #42863:
URL: https://github.com/apache/spark/pull/42863#issuecomment-1712980645
thanks, merged to master and branch-3.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #42863: [SPARK-45109][SQL][CONNECT] Fix aes_decrypt and ln functions in Connect
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #42863: [SPARK-45109][SQL][CONNECT] Fix aes_decrypt and ln functions in Connect
URL: https://github.com/apache/spark/pull/42863
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #42863: [SPARK-45109][SQL][CONNECT] Fix eas_decrypt and ln functions in Connect
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42863:
URL: https://github.com/apache/spark/pull/42863#issuecomment-1712779217
Could you re-trigger the CI again, @peter-toth ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #42863: [SPARK-45109][SQL][CONNECT] Fix eas_decrypt and ln functions in Connect
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42863:
URL: https://github.com/apache/spark/pull/42863#issuecomment-1712779298
also cc @hvanhovell
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #42863: [SPARK-45109][SQL][CONNECT] Fix eas_decrypt and ln functions in Connect
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #42863:
URL: https://github.com/apache/spark/pull/42863#issuecomment-1712806417
@peter-toth Good catch! But this PR may need to be corrected: eas_encrypt -> aes_ encrypt 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] peter-toth commented on pull request #42863: [SPARK-45109][SQL][CONNECT] Fix eas_decrypt and ln functions in Connect
Posted by "peter-toth (via GitHub)" <gi...@apache.org>.
peter-toth commented on PR #42863:
URL: https://github.com/apache/spark/pull/42863#issuecomment-1712762422
cc @xuanyuanking, @panbingkun, @zhengruifeng, @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org