You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/09/27 14:26:27 UTC
[GitHub] [skywalking] mrproliu opened a new pull request #7821: Add tag management to e2e-v2
mrproliu opened a new pull request #7821:
URL: https://github.com/apache/skywalking/pull/7821
### Continue https://github.com/apache/skywalking/pull/7810, add tag management
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [x] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7821: Add tag management to e2e-v2
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7821:
URL: https://github.com/apache/skywalking/pull/7821#discussion_r716755038
##########
File path: test/e2e-v2/script/env
##########
@@ -13,15 +13,6 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-ARG SW_AGENT_JDK_VERSION=8
-ARG SW_AGENT_JAVA_COMMIT=1f3c08a5af19f8522f2a40d9339c45fa816bfe07
-
-FROM ghcr.io/apache/skywalking-java/skywalking-java:${SW_AGENT_JAVA_COMMIT}-java${SW_AGENT_JDK_VERSION}
-
-VOLUME /services
-
-ENV SW_LOGGING_OUTPUT=CONSOLE
-
-ADD e2e-service-consumer/target/e2e-service-consumer-2.0.0.jar /services/
-
-CMD ["sh", "-c", "java -jar /services/e2e-service-consumer-2.0.0.jar"]
+SW_AGENT_JAVA_COMMIT=3997f0256056788bd054ee37e4603c11c0fd6756
+SW_AGENT_SATELLITE_COMMIT=1f3c08a5af19f8522f2a40d9339c45fa816bfe07
+SW_CTL_COMMIT=401e0e5671a3fb49de1d1e1e89f5b693b2062867
Review comment:
FYI @wankai123 We have this file controlling all tags now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7821: Add tag management to e2e-v2
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7821:
URL: https://github.com/apache/skywalking/pull/7821#discussion_r716755645
##########
File path: test/e2e-v2/cases/satellite/native-protocols/e2e.yaml
##########
@@ -19,6 +19,7 @@ setup:
env: compose
file: docker-compose.yml
timeout: 1200
+ init-system-environment: ../../../script/env
Review comment:
By using this loading the env.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #7821: Add tag management to e2e-v2
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #7821:
URL: https://github.com/apache/skywalking/pull/7821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org