You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by Neha Narkhede <ne...@gmail.com> on 2015/01/05 23:00:02 UTC

Re: Review Request 29210: Patch for KAFKA-1819

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29210/#review66733
-----------------------------------------------------------



core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala
<https://reviews.apache.org/r/29210/#comment110339>

    suggest moving this logic to verifyTopicDeletion. It is one of the important validity checks that checks if there are any deleted topics in the cleaner checkpoint.


- Neha Narkhede


On Dec. 31, 2014, 12:01 a.m., Gwen Shapira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29210/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2014, 12:01 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1819
>     https://issues.apache.org/jira/browse/KAFKA-1819
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> added locking
> 
> 
> improved tests per Joel and Neha's suggestions
> 
> 
> added cleaner test to DeleteTopicTest
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/log/LogCleaner.scala f8fcb843c80eec3cf3c931df6bb472c019305253 
>   core/src/main/scala/kafka/log/LogCleanerManager.scala bcfef77ed53f94017c06a884e4db14531774a0a2 
>   core/src/main/scala/kafka/log/LogManager.scala 4ebaae00ca4b80bf15c7930bae2011d98bbec053 
>   core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala 29cc01bcef9cacd8dec1f5d662644fc6fe4994bc 
>   core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala 5bfa764638e92f217d0ff7108ec8f53193c22978 
> 
> Diff: https://reviews.apache.org/r/29210/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gwen Shapira
> 
>