[GitHub] [druid] FrankChen021 commented on pull request #11262: Improve doc of movingAverage

[GitBox <gi...@apache.org>]

FrankChen021 commented on pull request #11262:
URL: https://github.com/apache/druid/pull/11262#issuecomment-844633988


   > > ### Description
   > > There're some questions about how to enable movingAverage on brokers(eg #11086), this PR improves the doc to make operational steps more directive and also adds a limitation that movingAverage is not supported by druid router.
   > > This PR has:
   > > 
   > > * [x]   been self-reviewed.
   > 
   > Actually, add binder.bind(c.class).to(FakeQuerySegmentWalker.class).in(LazySingleton.class) to CliRouter.java, users can query movingAverage through router. One line code can break this limit, but it is not very graceful because router not use QuerySegmentWalker.class.
   
   Thanks for pointing out this. Yes, we need to make some code change to support moving average running from router. This is not what this PR aims for. I'm planning to do it later or if you're interested in this feature, you could take it. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org