You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Fangmin Lv (JIRA)" <ji...@apache.org> on 2012/11/10 11:53:12 UTC
[jira] [Created] (BOOKKEEPER-460) LedgerDeleteTest checks wrong
place for log file
Fangmin Lv created BOOKKEEPER-460:
-------------------------------------
Summary: LedgerDeleteTest checks wrong place for log file
Key: BOOKKEEPER-460
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-460
Project: Bookkeeper
Issue Type: Test
Components: bookkeeper-server
Reporter: Fangmin Lv
Priority: Trivial
A minor problem, it seems forgot to update LedgerDeleteTest after upgrade bookkeeper filesystem.
{code:xml}
// Verify that the first entry log (0.log) has been deleted from all of the Bookie Servers.
for (File ledgerDirectory : tmpDirs) {
for (File f : ledgerDirectory.listFiles()) {
assertFalse("Found the entry log file (0.log) that should have been deleted in ledgerDirectory: "
+ ledgerDirectory, f.isFile() && f.getName().equals("0.log"));
}
}
{code}
Solution:
Just reuse the checkLogFiles method in CompactionTest.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-460) LedgerDeleteTest checks wrong
place for log file
Posted by "Fangmin Lv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fangmin Lv updated BOOKKEEPER-460:
----------------------------------
Attachment: BOOKKEEPER-460.diff
Move the TestUtils under util package as Flavio and sijie suggestion.
> LedgerDeleteTest checks wrong place for log file
> ------------------------------------------------
>
> Key: BOOKKEEPER-460
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-460
> Project: Bookkeeper
> Issue Type: Test
> Components: bookkeeper-server
> Reporter: Fangmin Lv
> Assignee: Fangmin Lv
> Priority: Trivial
> Attachments: BOOKKEEPER-460.diff, BOOKKEEPER-460.diff
>
>
> A minor problem, it seems forgot to update LedgerDeleteTest after upgrade bookkeeper filesystem.
> {code:xml}
> // Verify that the first entry log (0.log) has been deleted from all of the Bookie Servers.
> for (File ledgerDirectory : tmpDirs) {
> for (File f : ledgerDirectory.listFiles()) {
> assertFalse("Found the entry log file (0.log) that should have been deleted in ledgerDirectory: "
> + ledgerDirectory, f.isFile() && f.getName().equals("0.log"));
> }
> }
> {code}
> Solution:
> Just reuse the checkLogFiles method in CompactionTest.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-460) LedgerDeleteTest checks wrong
place for log file
Posted by "Fangmin Lv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fangmin Lv updated BOOKKEEPER-460:
----------------------------------
Attachment: BOOKKEEPER-460.patch
@Ivan
Good idea, submit a patch according to your proposal.
> LedgerDeleteTest checks wrong place for log file
> ------------------------------------------------
>
> Key: BOOKKEEPER-460
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-460
> Project: Bookkeeper
> Issue Type: Test
> Components: bookkeeper-server
> Reporter: Fangmin Lv
> Assignee: Fangmin Lv
> Priority: Trivial
> Attachments: BOOKKEEPER-460.diff, BOOKKEEPER-460.diff, BOOKKEEPER-460.patch
>
>
> A minor problem, it seems forgot to update LedgerDeleteTest after upgrade bookkeeper filesystem.
> {code:xml}
> // Verify that the first entry log (0.log) has been deleted from all of the Bookie Servers.
> for (File ledgerDirectory : tmpDirs) {
> for (File f : ledgerDirectory.listFiles()) {
> assertFalse("Found the entry log file (0.log) that should have been deleted in ledgerDirectory: "
> + ledgerDirectory, f.isFile() && f.getName().equals("0.log"));
> }
> }
> {code}
> Solution:
> Just reuse the checkLogFiles method in CompactionTest.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-460) LedgerDeleteTest checks wrong
place for log file
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496932#comment-13496932 ]
Sijie Guo commented on BOOKKEEPER-460:
--------------------------------------
I agreed putting in src/test/java/org/apache/bookkeeper/util as Flavio proposed, other than in bookie package.
> LedgerDeleteTest checks wrong place for log file
> ------------------------------------------------
>
> Key: BOOKKEEPER-460
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-460
> Project: Bookkeeper
> Issue Type: Test
> Components: bookkeeper-server
> Reporter: Fangmin Lv
> Priority: Trivial
> Attachments: BOOKKEEPER-460.diff
>
>
> A minor problem, it seems forgot to update LedgerDeleteTest after upgrade bookkeeper filesystem.
> {code:xml}
> // Verify that the first entry log (0.log) has been deleted from all of the Bookie Servers.
> for (File ledgerDirectory : tmpDirs) {
> for (File f : ledgerDirectory.listFiles()) {
> assertFalse("Found the entry log file (0.log) that should have been deleted in ledgerDirectory: "
> + ledgerDirectory, f.isFile() && f.getName().equals("0.log"));
> }
> }
> {code}
> Solution:
> Just reuse the checkLogFiles method in CompactionTest.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-460) LedgerDeleteTest checks wrong
place for log file
Posted by "Fangmin Lv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fangmin Lv updated BOOKKEEPER-460:
----------------------------------
Attachment: BOOKKEEPER-460.diff
> LedgerDeleteTest checks wrong place for log file
> ------------------------------------------------
>
> Key: BOOKKEEPER-460
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-460
> Project: Bookkeeper
> Issue Type: Test
> Components: bookkeeper-server
> Reporter: Fangmin Lv
> Priority: Trivial
> Attachments: BOOKKEEPER-460.diff
>
>
> A minor problem, it seems forgot to update LedgerDeleteTest after upgrade bookkeeper filesystem.
> {code:xml}
> // Verify that the first entry log (0.log) has been deleted from all of the Bookie Servers.
> for (File ledgerDirectory : tmpDirs) {
> for (File f : ledgerDirectory.listFiles()) {
> assertFalse("Found the entry log file (0.log) that should have been deleted in ledgerDirectory: "
> + ledgerDirectory, f.isFile() && f.getName().equals("0.log"));
> }
> }
> {code}
> Solution:
> Just reuse the checkLogFiles method in CompactionTest.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (BOOKKEEPER-460) LedgerDeleteTest checks wrong
place for log file
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Junqueira reassigned BOOKKEEPER-460:
-------------------------------------------
Assignee: Fangmin Lv
> LedgerDeleteTest checks wrong place for log file
> ------------------------------------------------
>
> Key: BOOKKEEPER-460
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-460
> Project: Bookkeeper
> Issue Type: Test
> Components: bookkeeper-server
> Reporter: Fangmin Lv
> Assignee: Fangmin Lv
> Priority: Trivial
> Attachments: BOOKKEEPER-460.diff
>
>
> A minor problem, it seems forgot to update LedgerDeleteTest after upgrade bookkeeper filesystem.
> {code:xml}
> // Verify that the first entry log (0.log) has been deleted from all of the Bookie Servers.
> for (File ledgerDirectory : tmpDirs) {
> for (File f : ledgerDirectory.listFiles()) {
> assertFalse("Found the entry log file (0.log) that should have been deleted in ledgerDirectory: "
> + ledgerDirectory, f.isFile() && f.getName().equals("0.log"));
> }
> }
> {code}
> Solution:
> Just reuse the checkLogFiles method in CompactionTest.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-460) LedgerDeleteTest checks wrong
place for log file
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13494637#comment-13494637 ]
Flavio Junqueira commented on BOOKKEEPER-460:
---------------------------------------------
Thanks for the patch, Fangmin. I'm mostly ok with the patch. The only point I'm not really happy about is creating a new class to hold checkLogFiles. Can't we have it in some other base class or utility class that already exists? To be honest, I looked into it and couldn't find a better place, so if anyone else has a suggestion, please comment. In the case we do create a new class, it might be better to have it in the util package.
> LedgerDeleteTest checks wrong place for log file
> ------------------------------------------------
>
> Key: BOOKKEEPER-460
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-460
> Project: Bookkeeper
> Issue Type: Test
> Components: bookkeeper-server
> Reporter: Fangmin Lv
> Priority: Trivial
> Attachments: BOOKKEEPER-460.diff
>
>
> A minor problem, it seems forgot to update LedgerDeleteTest after upgrade bookkeeper filesystem.
> {code:xml}
> // Verify that the first entry log (0.log) has been deleted from all of the Bookie Servers.
> for (File ledgerDirectory : tmpDirs) {
> for (File f : ledgerDirectory.listFiles()) {
> assertFalse("Found the entry log file (0.log) that should have been deleted in ledgerDirectory: "
> + ledgerDirectory, f.isFile() && f.getName().equals("0.log"));
> }
> }
> {code}
> Solution:
> Just reuse the checkLogFiles method in CompactionTest.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-460) LedgerDeleteTest checks wrong
place for log file
Posted by "Fangmin Lv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13494698#comment-13494698 ]
Fangmin Lv commented on BOOKKEEPER-460:
---------------------------------------
Hi Flavio, I agree with your point, I don't want to create a new class either, as you say there is not a place for keeping the common used methods. What about keep the checkLogFiles in the CompactionTest as a static method, Anybody please give some suggestion?
> LedgerDeleteTest checks wrong place for log file
> ------------------------------------------------
>
> Key: BOOKKEEPER-460
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-460
> Project: Bookkeeper
> Issue Type: Test
> Components: bookkeeper-server
> Reporter: Fangmin Lv
> Priority: Trivial
> Attachments: BOOKKEEPER-460.diff
>
>
> A minor problem, it seems forgot to update LedgerDeleteTest after upgrade bookkeeper filesystem.
> {code:xml}
> // Verify that the first entry log (0.log) has been deleted from all of the Bookie Servers.
> for (File ledgerDirectory : tmpDirs) {
> for (File f : ledgerDirectory.listFiles()) {
> assertFalse("Found the entry log file (0.log) that should have been deleted in ledgerDirectory: "
> + ledgerDirectory, f.isFile() && f.getName().equals("0.log"));
> }
> }
> {code}
> Solution:
> Just reuse the checkLogFiles method in CompactionTest.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-460) LedgerDeleteTest checks wrong
place for log file
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503909#comment-13503909 ]
Hudson commented on BOOKKEEPER-460:
-----------------------------------
Integrated in bookkeeper-trunk #819 (See [https://builds.apache.org/job/bookkeeper-trunk/819/])
BOOKKEEPER-460: LedgerDeleteTest checks wrong place for log file (Fangmin Lv via ivank) [missing file] (Revision 1413700)
Result = SUCCESS
ivank :
Files :
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/util/TestUtils.java
> LedgerDeleteTest checks wrong place for log file
> ------------------------------------------------
>
> Key: BOOKKEEPER-460
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-460
> Project: Bookkeeper
> Issue Type: Test
> Components: bookkeeper-server
> Reporter: Fangmin Lv
> Assignee: Fangmin Lv
> Priority: Trivial
> Attachments: BOOKKEEPER-460.diff, BOOKKEEPER-460.diff, BOOKKEEPER-460.patch
>
>
> A minor problem, it seems forgot to update LedgerDeleteTest after upgrade bookkeeper filesystem.
> {code:xml}
> // Verify that the first entry log (0.log) has been deleted from all of the Bookie Servers.
> for (File ledgerDirectory : tmpDirs) {
> for (File f : ledgerDirectory.listFiles()) {
> assertFalse("Found the entry log file (0.log) that should have been deleted in ledgerDirectory: "
> + ledgerDirectory, f.isFile() && f.getName().equals("0.log"));
> }
> }
> {code}
> Solution:
> Just reuse the checkLogFiles method in CompactionTest.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-460) LedgerDeleteTest checks wrong
place for log file
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503857#comment-13503857 ]
Hudson commented on BOOKKEEPER-460:
-----------------------------------
Integrated in bookkeeper-trunk #818 (See [https://builds.apache.org/job/bookkeeper-trunk/818/])
BOOKKEEPER-460: LedgerDeleteTest checks wrong place for log file (Fangmin Lv via ivank) (Revision 1413685)
Result = FAILURE
ivank :
Files :
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/CompactionTest.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/LedgerDeleteTest.java
> LedgerDeleteTest checks wrong place for log file
> ------------------------------------------------
>
> Key: BOOKKEEPER-460
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-460
> Project: Bookkeeper
> Issue Type: Test
> Components: bookkeeper-server
> Reporter: Fangmin Lv
> Assignee: Fangmin Lv
> Priority: Trivial
> Attachments: BOOKKEEPER-460.diff, BOOKKEEPER-460.diff, BOOKKEEPER-460.patch
>
>
> A minor problem, it seems forgot to update LedgerDeleteTest after upgrade bookkeeper filesystem.
> {code:xml}
> // Verify that the first entry log (0.log) has been deleted from all of the Bookie Servers.
> for (File ledgerDirectory : tmpDirs) {
> for (File f : ledgerDirectory.listFiles()) {
> assertFalse("Found the entry log file (0.log) that should have been deleted in ledgerDirectory: "
> + ledgerDirectory, f.isFile() && f.getName().equals("0.log"));
> }
> }
> {code}
> Solution:
> Just reuse the checkLogFiles method in CompactionTest.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-460) LedgerDeleteTest checks wrong
place for log file
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496938#comment-13496938 ]
Sijie Guo commented on BOOKKEEPER-460:
--------------------------------------
Flavio, Could you help adding Fangmin in the contributors list and assign this jira to him? I could not find him in the list.
> LedgerDeleteTest checks wrong place for log file
> ------------------------------------------------
>
> Key: BOOKKEEPER-460
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-460
> Project: Bookkeeper
> Issue Type: Test
> Components: bookkeeper-server
> Reporter: Fangmin Lv
> Priority: Trivial
> Attachments: BOOKKEEPER-460.diff
>
>
> A minor problem, it seems forgot to update LedgerDeleteTest after upgrade bookkeeper filesystem.
> {code:xml}
> // Verify that the first entry log (0.log) has been deleted from all of the Bookie Servers.
> for (File ledgerDirectory : tmpDirs) {
> for (File f : ledgerDirectory.listFiles()) {
> assertFalse("Found the entry log file (0.log) that should have been deleted in ledgerDirectory: "
> + ledgerDirectory, f.isFile() && f.getName().equals("0.log"));
> }
> }
> {code}
> Solution:
> Just reuse the checkLogFiles method in CompactionTest.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira