You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Julie Tibshirani (Jira)" <ji...@apache.org> on 2021/01/28 22:08:00 UTC
[jira] [Comment Edited] (LUCENE-9616) Improve test coverage for
internal format versions
[ https://issues.apache.org/jira/browse/LUCENE-9616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274026#comment-17274026 ]
Julie Tibshirani edited comment on LUCENE-9616 at 1/28/21, 10:07 PM:
---------------------------------------------------------------------
It sounds like we're on the same page. I'll close this in favor of LUCENE-9705, as that will address the concern going forward and I don't think we should refactor any formats that already live in backwards-codecs. Thanks [~ivera] for the nice idea of folding the two efforts together.
was (Author: julietibs):
It sounds like we're on the same page. I'll close this in favor of LUCENE-9705, as I don't think we should try to refactor any formats that already live in backwards-codecs. Thanks [~ivera] for the nice idea of folding the two efforts together.
> Improve test coverage for internal format versions
> --------------------------------------------------
>
> Key: LUCENE-9616
> URL: https://issues.apache.org/jira/browse/LUCENE-9616
> Project: Lucene - Core
> Issue Type: Test
> Reporter: Julie Tibshirani
> Priority: Minor
>
> Some formats use an internal versioning system -- for example {{CompressingStoredFieldsFormat}} maintains older logic for reading an on-heap fields index. Because we always allow reading segments from the current + previous major version, some users still rely on the read-side logic of older internal versions.
> Although the older version logic is covered by {{TestBackwardsCompatibility}}, it looks like it's not exercised in unit tests. Older versions aren't "in rotation" when choosing a random codec for tests. They also don't have dedicated unit tests as we have for separate older formats, for example {{TestLucene60PointsFormat}}.
> It could be good to improve unit test coverage for the older versions, since they're in active use. A downside is that it's not straightforward to add unit tests, since we tend to just change/ delete the old write-side logic as we bump internal versions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org