You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by st...@apache.org on 2020/11/26 10:14:15 UTC

[hadoop] branch branch-3.3 updated: HADOOP-17396. ABFS: testRenameFileOverExistingFile fails (#2491)

This is an automated email from the ASF dual-hosted git repository.

stevel pushed a commit to branch branch-3.3
in repository https://gitbox.apache.org/repos/asf/hadoop.git


The following commit(s) were added to refs/heads/branch-3.3 by this push:
     new 39fa2c9  HADOOP-17396. ABFS: testRenameFileOverExistingFile fails (#2491)
39fa2c9 is described below

commit 39fa2c93c49f7b96340643d973195dbe89583518
Author: Sneha Vijayarajan <sn...@gmail.com>
AuthorDate: Thu Nov 26 15:41:25 2020 +0530

    HADOOP-17396. ABFS: testRenameFileOverExistingFile fails (#2491)
    
    Contributed by Sneha  Vijayarajan.
    
    Change-Id: I57a866b95ff18229caee8a6028874074a29cb5bd
---
 .../fs/azurebfs/contract/ITestAbfsFileSystemContractRename.java      | 5 +++++
 hadoop-tools/hadoop-azure/src/test/resources/azure-test.xml          | 5 +++++
 2 files changed, 10 insertions(+)

diff --git a/hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/contract/ITestAbfsFileSystemContractRename.java b/hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/contract/ITestAbfsFileSystemContractRename.java
index b92bef6..cd60e6d 100644
--- a/hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/contract/ITestAbfsFileSystemContractRename.java
+++ b/hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/contract/ITestAbfsFileSystemContractRename.java
@@ -38,6 +38,11 @@ public class ITestAbfsFileSystemContractRename extends AbstractContractRenameTes
   public void setup() throws Exception {
     binding.setup();
     super.setup();
+    // Base rename contract test class re-uses the test folder
+    // This leads to failures when the test is re-run as same ABFS test
+    // containers are re-used for test run and creation of source and
+    // destination test paths fail, as they are already present.
+    binding.getFileSystem().delete(binding.getTestPath(), true);
   }
 
   @Override
diff --git a/hadoop-tools/hadoop-azure/src/test/resources/azure-test.xml b/hadoop-tools/hadoop-azure/src/test/resources/azure-test.xml
index d43d67e..069b13e 100644
--- a/hadoop-tools/hadoop-azure/src/test/resources/azure-test.xml
+++ b/hadoop-tools/hadoop-azure/src/test/resources/azure-test.xml
@@ -38,6 +38,11 @@
     <value>false</value>
   </property>
 
+  <property>
+    <name>fs.contract.rename-returns-false-if-dest-exists</name>
+    <value>true</value>
+  </property>
+
   <!--====================  ABFS CONFIGURATION ====================-->
   <!-- SEE relevant section in "site/markdown/testing_azure.md"-->
 


---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org