You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Sergio Pena via Review Board <no...@reviews.apache.org> on 2018/06/01 20:47:17 UTC
Review Request 67419: SENTRY-2256: Make thrift API changes to get user
privileges from Sentry
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67419/
-----------------------------------------------------------
Review request for sentry, kalyan kumar kalvagadda and Na Li.
Bugs: SENTRY-2256
https://issues.apache.org/jira/browse/SENTRY-2256
Repository: sentry
Description
-------
This subtask will add new thrift API changes to allow Sentry clients to request user privileges from the Sentry server.
Functions added:
TListSentryPrivilegesResponse list_sentry_privileges_by_user(1:TSentryPrivilegeRequest request)
Structs added:
TSentryPrivilegeRequest which is a generic structure that allows to pass any type of entity name (TListSentryPrivilegseRequest knows about roleName only)
Structds modified:
TListSentryPrivilegesByAuthRequest adds a new parameter to specify the list of users to get privileges for.
TListSentryPrivilegesByAuthResponse adds a new parameter to get the list of privileges of the specified users.
Diffs
-----
sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/SentryPolicyService.java cc9a682e21dec7db201caeb61c111265c23f7ae8
sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TListSentryPrivilegesByAuthRequest.java bcc359e7e3a300945a115b0df15faf307ef94fab
sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TListSentryPrivilegesByAuthResponse.java c0a7f1878f78142f85d57899d30238cc381e2b3f
sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryHmsEventNotification.java 75b2799d8777bcae6ba64b575806bf64a82c5f49
sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryMappingData.java 4e69a0c04254ab3e9621e490c97240439172c900
sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryObjectOwnerType.java 6b540b88241abf4cb87246082b481f2b4c6fdca2
sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryPrivilegeRequest.java PRE-CREATION
sentry-service/sentry-service-api/src/main/resources/sentry_policy_service.thrift 679ab5694ab326692840c7d8fbad8532a7f4b396
Diff: https://reviews.apache.org/r/67419/diff/1/
Testing
-------
Thanks,
Sergio Pena
Re: Review Request 67419: SENTRY-2256: Make thrift API changes to get
user privileges from Sentry
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67419/#review204268
-----------------------------------------------------------
Ship it!
Ship It!
- Na Li
On June 4, 2018, 5:08 p.m., Sergio Pena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67419/
> -----------------------------------------------------------
>
> (Updated June 4, 2018, 5:08 p.m.)
>
>
> Review request for sentry, kalyan kumar kalvagadda and Na Li.
>
>
> Bugs: SENTRY-2256
> https://issues.apache.org/jira/browse/SENTRY-2256
>
>
> Repository: sentry
>
>
> Description
> -------
>
> This subtask will add new thrift API changes to allow Sentry clients to request user privileges from the Sentry server.
>
> Functions added:
> TListSentryPrivilegesResponse list_sentry_privileges_by_user(1:TListSentryPrivilegesRequest request)
>
> Structds modified:
> TListSentryPrivilegesResponse adds a new parameter to specify the entityName. It is not necessary to specify the entity type because this message
> will be used either by list_sentry_privileges_by_role or list_sentry_privileges_by_user
>
> TListSentryPrivilegesByAuthRequest adds a new parameter to specify the list of users to get privileges for.
> TListSentryPrivilegesByAuthResponse adds a new parameter to get the list of privileges of the specified users.
>
>
> Diffs
> -----
>
> sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/SentryPolicyService.java cc9a682e21dec7db201caeb61c111265c23f7ae8
> sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TListSentryPrivilegesByAuthRequest.java bcc359e7e3a300945a115b0df15faf307ef94fab
> sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TListSentryPrivilegesByAuthResponse.java c0a7f1878f78142f85d57899d30238cc381e2b3f
> sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TListSentryPrivilegesRequest.java 4da184080ace2dc1a96b016b60e7c5dbf5dd2d76
> sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryMappingData.java 4e69a0c04254ab3e9621e490c97240439172c900
> sentry-service/sentry-service-api/src/main/resources/sentry_policy_service.thrift 679ab5694ab326692840c7d8fbad8532a7f4b396
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java 71ea84f04da2789cf824f823c0a15a3d2a448f4b
>
>
> Diff: https://reviews.apache.org/r/67419/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergio Pena
>
>
Re: Review Request 67419: SENTRY-2256: Make thrift API changes to get
user privileges from Sentry
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67419/
-----------------------------------------------------------
(Updated June 4, 2018, 5:08 p.m.)
Review request for sentry, kalyan kumar kalvagadda and Na Li.
Bugs: SENTRY-2256
https://issues.apache.org/jira/browse/SENTRY-2256
Repository: sentry
Description
-------
This subtask will add new thrift API changes to allow Sentry clients to request user privileges from the Sentry server.
Functions added:
TListSentryPrivilegesResponse list_sentry_privileges_by_user(1:TListSentryPrivilegesRequest request)
Structds modified:
TListSentryPrivilegesResponse adds a new parameter to specify the entityName. It is not necessary to specify the entity type because this message
will be used either by list_sentry_privileges_by_role or list_sentry_privileges_by_user
TListSentryPrivilegesByAuthRequest adds a new parameter to specify the list of users to get privileges for.
TListSentryPrivilegesByAuthResponse adds a new parameter to get the list of privileges of the specified users.
Diffs (updated)
-----
sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/SentryPolicyService.java cc9a682e21dec7db201caeb61c111265c23f7ae8
sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TListSentryPrivilegesByAuthRequest.java bcc359e7e3a300945a115b0df15faf307ef94fab
sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TListSentryPrivilegesByAuthResponse.java c0a7f1878f78142f85d57899d30238cc381e2b3f
sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TListSentryPrivilegesRequest.java 4da184080ace2dc1a96b016b60e7c5dbf5dd2d76
sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryMappingData.java 4e69a0c04254ab3e9621e490c97240439172c900
sentry-service/sentry-service-api/src/main/resources/sentry_policy_service.thrift 679ab5694ab326692840c7d8fbad8532a7f4b396
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java 71ea84f04da2789cf824f823c0a15a3d2a448f4b
Diff: https://reviews.apache.org/r/67419/diff/4/
Changes: https://reviews.apache.org/r/67419/diff/3-4/
Testing
-------
Thanks,
Sergio Pena
Re: Review Request 67419: SENTRY-2256: Make thrift API changes to get
user privileges from Sentry
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
> On June 4, 2018, 5:02 p.m., Na Li wrote:
> > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java
> > Lines 840 (patched)
> > <https://reviews.apache.org/r/67419/diff/2/?file=2034625#file2034625line840>
> >
> > should you put todo comment? It should be implemented in another jira
Do we need this TODO? This is a subtask and I'm waiting for this to implement the other jira.
- Sergio
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67419/#review204261
-----------------------------------------------------------
On June 4, 2018, 5:08 p.m., Sergio Pena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67419/
> -----------------------------------------------------------
>
> (Updated June 4, 2018, 5:08 p.m.)
>
>
> Review request for sentry, kalyan kumar kalvagadda and Na Li.
>
>
> Bugs: SENTRY-2256
> https://issues.apache.org/jira/browse/SENTRY-2256
>
>
> Repository: sentry
>
>
> Description
> -------
>
> This subtask will add new thrift API changes to allow Sentry clients to request user privileges from the Sentry server.
>
> Functions added:
> TListSentryPrivilegesResponse list_sentry_privileges_by_user(1:TListSentryPrivilegesRequest request)
>
> Structds modified:
> TListSentryPrivilegesResponse adds a new parameter to specify the entityName. It is not necessary to specify the entity type because this message
> will be used either by list_sentry_privileges_by_role or list_sentry_privileges_by_user
>
> TListSentryPrivilegesByAuthRequest adds a new parameter to specify the list of users to get privileges for.
> TListSentryPrivilegesByAuthResponse adds a new parameter to get the list of privileges of the specified users.
>
>
> Diffs
> -----
>
> sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/SentryPolicyService.java cc9a682e21dec7db201caeb61c111265c23f7ae8
> sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TListSentryPrivilegesByAuthRequest.java bcc359e7e3a300945a115b0df15faf307ef94fab
> sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TListSentryPrivilegesByAuthResponse.java c0a7f1878f78142f85d57899d30238cc381e2b3f
> sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TListSentryPrivilegesRequest.java 4da184080ace2dc1a96b016b60e7c5dbf5dd2d76
> sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryMappingData.java 4e69a0c04254ab3e9621e490c97240439172c900
> sentry-service/sentry-service-api/src/main/resources/sentry_policy_service.thrift 679ab5694ab326692840c7d8fbad8532a7f4b396
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java 71ea84f04da2789cf824f823c0a15a3d2a448f4b
>
>
> Diff: https://reviews.apache.org/r/67419/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergio Pena
>
>
Re: Review Request 67419: SENTRY-2256: Make thrift API changes to get
user privileges from Sentry
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67419/#review204261
-----------------------------------------------------------
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java
Lines 840 (patched)
<https://reviews.apache.org/r/67419/#comment286656>
should you put todo comment? It should be implemented in another jira
- Na Li
On June 4, 2018, 4:09 p.m., Sergio Pena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67419/
> -----------------------------------------------------------
>
> (Updated June 4, 2018, 4:09 p.m.)
>
>
> Review request for sentry, kalyan kumar kalvagadda and Na Li.
>
>
> Bugs: SENTRY-2256
> https://issues.apache.org/jira/browse/SENTRY-2256
>
>
> Repository: sentry
>
>
> Description
> -------
>
> This subtask will add new thrift API changes to allow Sentry clients to request user privileges from the Sentry server.
>
> Functions added:
> TListSentryPrivilegesResponse list_sentry_privileges_by_user(1:TListSentryPrivilegesRequest request)
>
> Structds modified:
> TListSentryPrivilegesResponse adds a new parameter to specify the entityName. It is not necessary to specify the entity type because this message
> will be used either by list_sentry_privileges_by_role or list_sentry_privileges_by_user
>
> TListSentryPrivilegesByAuthRequest adds a new parameter to specify the list of users to get privileges for.
> TListSentryPrivilegesByAuthResponse adds a new parameter to get the list of privileges of the specified users.
>
>
> Diffs
> -----
>
> sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/SentryPolicyService.java cc9a682e21dec7db201caeb61c111265c23f7ae8
> sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TListSentryPrivilegesByAuthRequest.java bcc359e7e3a300945a115b0df15faf307ef94fab
> sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TListSentryPrivilegesByAuthResponse.java c0a7f1878f78142f85d57899d30238cc381e2b3f
> sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TListSentryPrivilegesRequest.java 4da184080ace2dc1a96b016b60e7c5dbf5dd2d76
> sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryMappingData.java 4e69a0c04254ab3e9621e490c97240439172c900
> sentry-service/sentry-service-api/src/main/resources/sentry_policy_service.thrift 679ab5694ab326692840c7d8fbad8532a7f4b396
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java 71ea84f04da2789cf824f823c0a15a3d2a448f4b
>
>
> Diff: https://reviews.apache.org/r/67419/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergio Pena
>
>
Re: Review Request 67419: SENTRY-2256: Make thrift API changes to get
user privileges from Sentry
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67419/
-----------------------------------------------------------
(Updated June 4, 2018, 4:09 p.m.)
Review request for sentry, kalyan kumar kalvagadda and Na Li.
Bugs: SENTRY-2256
https://issues.apache.org/jira/browse/SENTRY-2256
Repository: sentry
Description (updated)
-------
This subtask will add new thrift API changes to allow Sentry clients to request user privileges from the Sentry server.
Functions added:
TListSentryPrivilegesResponse list_sentry_privileges_by_user(1:TListSentryPrivilegesRequest request)
Structds modified:
TListSentryPrivilegesResponse adds a new parameter to specify the entityName. It is not necessary to specify the entity type because this message
will be used either by list_sentry_privileges_by_role or list_sentry_privileges_by_user
TListSentryPrivilegesByAuthRequest adds a new parameter to specify the list of users to get privileges for.
TListSentryPrivilegesByAuthResponse adds a new parameter to get the list of privileges of the specified users.
Diffs
-----
sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/SentryPolicyService.java cc9a682e21dec7db201caeb61c111265c23f7ae8
sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TListSentryPrivilegesByAuthRequest.java bcc359e7e3a300945a115b0df15faf307ef94fab
sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TListSentryPrivilegesByAuthResponse.java c0a7f1878f78142f85d57899d30238cc381e2b3f
sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TListSentryPrivilegesRequest.java 4da184080ace2dc1a96b016b60e7c5dbf5dd2d76
sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryMappingData.java 4e69a0c04254ab3e9621e490c97240439172c900
sentry-service/sentry-service-api/src/main/resources/sentry_policy_service.thrift 679ab5694ab326692840c7d8fbad8532a7f4b396
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java 71ea84f04da2789cf824f823c0a15a3d2a448f4b
Diff: https://reviews.apache.org/r/67419/diff/3/
Testing
-------
Thanks,
Sergio Pena
Re: Review Request 67419: SENTRY-2256: Make thrift API changes to get
user privileges from Sentry
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67419/
-----------------------------------------------------------
(Updated June 4, 2018, 4:08 p.m.)
Review request for sentry, kalyan kumar kalvagadda and Na Li.
Bugs: SENTRY-2256
https://issues.apache.org/jira/browse/SENTRY-2256
Repository: sentry
Description
-------
This subtask will add new thrift API changes to allow Sentry clients to request user privileges from the Sentry server.
Functions added:
TListSentryPrivilegesResponse list_sentry_privileges_by_user(1:TSentryPrivilegeRequest request)
Structs added:
TSentryPrivilegeRequest which is a generic structure that allows to pass any type of entity name (TListSentryPrivilegseRequest knows about roleName only)
Structds modified:
TListSentryPrivilegesByAuthRequest adds a new parameter to specify the list of users to get privileges for.
TListSentryPrivilegesByAuthResponse adds a new parameter to get the list of privileges of the specified users.
Diffs (updated)
-----
sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/SentryPolicyService.java cc9a682e21dec7db201caeb61c111265c23f7ae8
sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TListSentryPrivilegesByAuthRequest.java bcc359e7e3a300945a115b0df15faf307ef94fab
sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TListSentryPrivilegesByAuthResponse.java c0a7f1878f78142f85d57899d30238cc381e2b3f
sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TListSentryPrivilegesRequest.java 4da184080ace2dc1a96b016b60e7c5dbf5dd2d76
sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryMappingData.java 4e69a0c04254ab3e9621e490c97240439172c900
sentry-service/sentry-service-api/src/main/resources/sentry_policy_service.thrift 679ab5694ab326692840c7d8fbad8532a7f4b396
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java 71ea84f04da2789cf824f823c0a15a3d2a448f4b
Diff: https://reviews.apache.org/r/67419/diff/3/
Changes: https://reviews.apache.org/r/67419/diff/2-3/
Testing
-------
Thanks,
Sergio Pena
Re: Review Request 67419: SENTRY-2256: Make thrift API changes to get
user privileges from Sentry
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67419/
-----------------------------------------------------------
(Updated June 1, 2018, 8:50 p.m.)
Review request for sentry, kalyan kumar kalvagadda and Na Li.
Bugs: SENTRY-2256
https://issues.apache.org/jira/browse/SENTRY-2256
Repository: sentry
Description
-------
This subtask will add new thrift API changes to allow Sentry clients to request user privileges from the Sentry server.
Functions added:
TListSentryPrivilegesResponse list_sentry_privileges_by_user(1:TSentryPrivilegeRequest request)
Structs added:
TSentryPrivilegeRequest which is a generic structure that allows to pass any type of entity name (TListSentryPrivilegseRequest knows about roleName only)
Structds modified:
TListSentryPrivilegesByAuthRequest adds a new parameter to specify the list of users to get privileges for.
TListSentryPrivilegesByAuthResponse adds a new parameter to get the list of privileges of the specified users.
Diffs (updated)
-----
sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/SentryPolicyService.java cc9a682e21dec7db201caeb61c111265c23f7ae8
sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TListSentryPrivilegesByAuthRequest.java bcc359e7e3a300945a115b0df15faf307ef94fab
sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TListSentryPrivilegesByAuthResponse.java c0a7f1878f78142f85d57899d30238cc381e2b3f
sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryHmsEventNotification.java 75b2799d8777bcae6ba64b575806bf64a82c5f49
sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryMappingData.java 4e69a0c04254ab3e9621e490c97240439172c900
sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryObjectOwnerType.java 6b540b88241abf4cb87246082b481f2b4c6fdca2
sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryPrivilegeRequest.java PRE-CREATION
sentry-service/sentry-service-api/src/main/resources/sentry_policy_service.thrift 679ab5694ab326692840c7d8fbad8532a7f4b396
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java 71ea84f04da2789cf824f823c0a15a3d2a448f4b
Diff: https://reviews.apache.org/r/67419/diff/2/
Changes: https://reviews.apache.org/r/67419/diff/1-2/
Testing
-------
Thanks,
Sergio Pena