[GitHub] [incubator-pinot] jackjlli commented on pull request #6887: Remove realtime segment metrics if it's destroyed

[GitBox <gi...@apache.org>]

jackjlli commented on pull request #6887:
URL: https://github.com/apache/incubator-pinot/pull/6887#issuecomment-837094283


   > 1. I assume YammerMetrics works correctly when metrics are added or remove at the same time. It is possible that the destroy()  method is called even as a new consuming segment gets added to a host.
   > 2. You should add a comment in javadocs `PinotMetricsRegistry` interface that it should be thread-safe against adds and removes of the same metric.
   > 3. Add a comment here as well, saying we expect the add/remove to work correctly in  case of being invoked across multiple threads.
   
   1. Correct, yammer metrics works correctly on handling add and remove at the same time.
   2.3. Comments added. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org