You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by "rkondakov (via GitHub)" <gi...@apache.org> on 2023/04/24 07:35:21 UTC

[GitHub] [calcite] rkondakov commented on a diff in pull request #3172: [CALCITE-5670] Assertion error in SemiJoinJoinTransposeRule

rkondakov commented on code in PR #3172:
URL: https://github.com/apache/calcite/pull/3172#discussion_r1174893983


##########
core/src/main/java/org/apache/calcite/rel/rules/SemiJoinJoinTransposeRule.java:
##########
@@ -102,16 +101,18 @@ public SemiJoinJoinTransposeRule(RelBuilderFactory relBuilderFactory) {
 
     // determine which operands below the semi-join are the actual
     // Rels that participate in the semi-join
+    final ImmutableIntList leftKeys = semiJoin.analyzeCondition().leftKeys;

Review Comment:
   The `leftKeys` variable was defined much earlier than the place where it was actually used. I moved it closer to this place to improve code readability.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org