You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/08/30 23:06:33 UTC
[GitHub] [hadoop] bharatviswa504 commented on a change in pull request
#1387: HDDS-2065. Implement OMNodeDetails#toString
bharatviswa504 commented on a change in pull request #1387: HDDS-2065. Implement OMNodeDetails#toString
URL: https://github.com/apache/hadoop/pull/1387#discussion_r319696118
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMNodeDetails.java
##########
@@ -54,6 +54,19 @@ private OMNodeDetails(String serviceId, String nodeId,
this.httpsAddress = httpsAddress;
}
+ @Override
+ public String toString() {
+ return "OMNodeDetails["
+ + "omServiceId=" + omServiceId +
+ ", omNodeId=" + omNodeId +
+ ", rpcAddress=" + rpcAddress +
+ ", rpcPort=" + rpcPort +
+ ", ratisPort=" + ratisPort +
Review comment:
Minor suggestion: Use StringBuilder instead of using "+".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org